Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vuln/vulncheck/internal/binscan: TestBinary failures #55219

Closed
gopherbot opened this issue Sep 20, 2022 · 4 comments
Closed

x/vuln/vulncheck/internal/binscan: TestBinary failures #55219

gopherbot opened this issue Sep 20, 2022 · 4 comments
Assignees
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo x/vuln
Milestone

Comments

@gopherbot
Copy link

#!watchflakes
post <- pkg == "golang.org/x/vuln/vulncheck/internal/binscan" && test == "TestBinary"

Bug automatically created to track these flakes.

— watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2022
@gopherbot
Copy link
Author

gopherbot commented Sep 20, 2022

Found new matching flaky dashboard failures for:

#!watchflakes
post <- pkg == "golang.org/x/vuln/vulncheck/internal/binscan" && test == "TestBinary"
2022-09-02 21:14 illumos-amd64 vuln@27dd78d2 go@8fd20736 golang.org/x/vuln/vulncheck/internal/binscan.TestBinary (log)
--- FAIL: TestBinary (3.14s)
panic: runtime error: slice bounds out of range [613566756:437264] [recovered]
	panic: runtime error: slice bounds out of range [613566756:437264]

goroutine 18 [running]:
testing.tRunner.func1.2({0x89dc80, 0xc00015a288})
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/testing/testing.go:1429 +0x24e
testing.tRunner.func1()
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/testing/testing.go:1432 +0x39f
panic({0x89dc80, 0xc00015a288})
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/runtime/panic.go:884 +0x213
golang.org/x/vuln/vulncheck/internal/gosym.(*LineTable).funcName(0xc00018a6c0, 0x24924924)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/vuln/vulncheck/internal/gosym/pclntab.go:450 +0x18a
golang.org/x/vuln/vulncheck/internal/gosym.(*LineTable).InlineTree(0xc00018a6c0, 0xc0000d5a98, 0x9?, 0x4?, {0x965480?, 0xc00007f140})
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/vuln/vulncheck/internal/gosym/pclntab.go:179 +0x1ec
golang.org/x/vuln/vulncheck/internal/binscan.ExtractPackagesAndSymbols({0x9655e0, 0xc000014138})
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/vuln/vulncheck/internal/binscan/scan.go:93 +0x4d6
golang.org/x/vuln/vulncheck.Binary({0x968ed8, 0xc0000ac000}, {0x9655e0?, 0xc000014138?}, 0xc0000d5e48)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/vuln/vulncheck/binary.go:27 +0xc5
golang.org/x/vuln/vulncheck.TestBinary(0xc000087040)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/vuln/vulncheck/binary_test.go:120 +0x650
testing.tRunner(0xc000087040, 0x903cc0)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/testing/testing.go:1479 +0x10b
created by testing.(*T).Run
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/testing/testing.go:1526 +0x35f

watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Sep 20, 2022
@rsc
Copy link
Contributor

rsc commented Sep 20, 2022

Stopped.

@rsc rsc closed this as completed Sep 20, 2022
@gopherbot gopherbot changed the title x/vuln/vulncheck/internal/binscan: flaky TestBinary x/vuln/vulncheck/internal/binscan: TestBinary failures Sep 20, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln/vulncheck/internal/binscan" && test == "TestBinary"
2023-02-01 22:29 windows-arm64-11 vuln@4c848edc go@103f3749 x/vuln/vulncheck/internal/binscan.TestBinary (log)
--- FAIL: TestBinary (0.52s)
    binary_test.go:106: failed to build the binary exit status 1 main.go:5:5: package archive/zip is not in GOROOT (C:\workdir\go\src\archive\zip)

watchflakes

@gopherbot gopherbot reopened this Feb 6, 2023
@gopherbot gopherbot added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Feb 6, 2023
@zpavlinovic zpavlinovic self-assigned this Sep 27, 2023
@zpavlinovic
Copy link
Contributor

Stopped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo x/vuln
Projects
Status: Done
Development

No branches or pull requests

3 participants