Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/regtest/misc: TestSimultaneousEdits failures #55182

Closed
gopherbot opened this issue Sep 20, 2022 · 2 comments
Closed

x/tools/gopls/internal/regtest/misc: TestSimultaneousEdits failures #55182

gopherbot opened this issue Sep 20, 2022 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestSimultaneousEdits"

Bug automatically created to track these flakes.

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2022
@gopherbot
Copy link
Author

gopherbot commented Sep 20, 2022 •
edited

Found new matching flaky dashboard failures for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestSimultaneousEdits"
2022-07-26 21:20 freebsd-386-13_0 tools@39a4e364 go@42481461 golang.org/x/tools/gopls/internal/regtest/misc.TestSimultaneousEdits (log) 
serve.go:442: debug server listening at http://localhost:18411
serve.go:442: debug server listening at http://localhost:18412
goroutine profile: total 16
2 @ 0x8084006 0x807d074 0x80ae68c 0x80e4f41 0x80e5dda 0x80e5dbf 0x80ee28c 0x80ee26c 0x813de7f 0x80e13f5 0x81955ee 0x81955c4 0x81960ee 0x80b2c21
#	0x80ae68b	internal/poll.runtime_pollWait+0x4b		/tmp/workdir/go/src/runtime/netpoll.go:305
#	0x80e4f40	internal/poll.(*pollDesc).wait+0x30		/tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:84
#	0x80e5dd9	internal/poll.(*pollDesc).waitRead+0x1d9	/tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:89
#	0x80e5dbe	internal/poll.(*FD).Read+0x1be			/tmp/workdir/go/src/internal/poll/fd_unix.go:167
#	0x80ee28b	os.(*File).read+0x5b				/tmp/workdir/go/src/os/file_posix.go:31
#	0x80ee26b	os.(*File).Read+0x3b				/tmp/workdir/go/src/os/file.go:118
...
#	0x80c4cc4	syscall.Syscall9+0x4						/tmp/workdir/go/src/syscall/asm_unix_386.s:70
#	0x80f4968	os.(*Process).blockUntilWaitable+0x68				/tmp/workdir/go/src/os/wait_wait6.go:26
#	0x80eda47	os.(*Process).wait+0x27						/tmp/workdir/go/src/os/exec_unix.go:22
#	0x81961a5	os.(*Process).Wait+0x45						/tmp/workdir/go/src/os/exec.go:132
#	0x819618d	os/exec.(*Cmd).Wait+0x2d					/tmp/workdir/go/src/os/exec/exec.go:594
#	0x82cb260	golang.org/x/tools/internal/gocommand.runCmdContext.func1+0x20	/tmp/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:243

--- FAIL: TestSimultaneousEdits (1.00s)
    --- FAIL: TestSimultaneousEdits/default (1.00s)
        runner.go:369: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /tmp/workdir/tmp/gopls-regtest-1584938029/TestSimultaneousEdits/default: directory not empty
2022-07-28 20:06 darwin-amd64-nocgo tools@8ea56879 go@d9242f7a golang.org/x/tools/gopls/internal/regtest/misc.TestSimultaneousEdits (log) 
serve.go:442: debug server listening at http://localhost:49415
serve.go:442: debug server listening at http://localhost:49416
goroutine profile: total 16
2 @ 0x1037ed6 0x10306d7 0x1062c65 0x109aaf2 0x109be5a 0x109be48 0x10a32fe 0x10a32f6 0x10f3df8 0x109776b 0x1252dda 0x1252dc6 0x1253a25 0x1068b61
#	0x1062c64	internal/poll.runtime_pollWait+0x84		/Users/gopher/workdir/go/src/runtime/netpoll.go:303
#	0x109aaf1	internal/poll.(*pollDesc).wait+0x31		/Users/gopher/workdir/go/src/internal/poll/fd_poll_runtime.go:84
#	0x109be59	internal/poll.(*pollDesc).waitRead+0x259	/Users/gopher/workdir/go/src/internal/poll/fd_poll_runtime.go:89
#	0x109be47	internal/poll.(*FD).Read+0x247			/Users/gopher/workdir/go/src/internal/poll/fd_unix.go:167
#	0x10a32fd	os.(*File).read+0x5d				/Users/gopher/workdir/go/src/os/file_posix.go:32
#	0x10a32f5	os.(*File).Read+0x55				/Users/gopher/workdir/go/src/os/file.go:119
...
#	0x1078c67	syscall.wait4+0x47						/Users/gopher/workdir/go/src/syscall/zsyscall_darwin_amd64.go:44
#	0x1076d6a	syscall.Wait4+0x2a						/Users/gopher/workdir/go/src/syscall/syscall_bsd.go:145
#	0x10a2cb6	os.(*Process).wait+0x76						/Users/gopher/workdir/go/src/os/exec_unix.go:44
#	0x1253b13	os.(*Process).Wait+0x53						/Users/gopher/workdir/go/src/os/exec.go:132
#	0x1253aff	os/exec.(*Cmd).Wait+0x3f					/Users/gopher/workdir/go/src/os/exec/exec.go:510
#	0x1286b45	golang.org/x/tools/internal/gocommand.runCmdContext.func1+0x25	/Users/gopher/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:243

--- FAIL: TestSimultaneousEdits (1.23s)
    --- FAIL: TestSimultaneousEdits/default (1.23s)
        runner.go:369: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /Users/gopher/workdir/tmp/gopls-regtest-1386127039/TestSimultaneousEdits/default: directory not empty
2022-08-02 16:05 darwin-amd64-nocgo tools@4d0b3834 go@1b7e71e8 golang.org/x/tools/gopls/internal/regtest/misc.TestSimultaneousEdits (log) 
serve.go:442: debug server listening at http://localhost:49419
serve.go:442: debug server listening at http://localhost:49420
goroutine profile: total 16
2 @ 0x1039d36 0x1032dd7 0x10658a9 0x10a0b32 0x10a1e9a 0x10a1e88 0x10ab8fe 0x10ab8f6 0x10ff218 0x109d00b 0x115fe1a 0x115fe06 0x1160bc5 0x106be41
#	0x10658a8	internal/poll.runtime_pollWait+0x88		/Users/gopher/workdir/go/src/runtime/netpoll.go:305
#	0x10a0b31	internal/poll.(*pollDesc).wait+0x31		/Users/gopher/workdir/go/src/internal/poll/fd_poll_runtime.go:84
#	0x10a1e99	internal/poll.(*pollDesc).waitRead+0x259	/Users/gopher/workdir/go/src/internal/poll/fd_poll_runtime.go:89
#	0x10a1e87	internal/poll.(*FD).Read+0x247			/Users/gopher/workdir/go/src/internal/poll/fd_unix.go:167
#	0x10ab8fd	os.(*File).read+0x5d				/Users/gopher/workdir/go/src/os/file_posix.go:31
#	0x10ab8f5	os.(*File).Read+0x55				/Users/gopher/workdir/go/src/os/file.go:118
...
#	0x107d1a7	syscall.wait4+0x47						/Users/gopher/workdir/go/src/syscall/zsyscall_darwin_amd64.go:43
#	0x107a24a	syscall.Wait4+0x2a						/Users/gopher/workdir/go/src/syscall/syscall_bsd.go:144
#	0x10ab2b6	os.(*Process).wait+0x76						/Users/gopher/workdir/go/src/os/exec_unix.go:43
#	0x1160c8a	os.(*Process).Wait+0x4a						/Users/gopher/workdir/go/src/os/exec.go:132
#	0x1160c7c	os/exec.(*Cmd).Wait+0x3c					/Users/gopher/workdir/go/src/os/exec/exec.go:599
#	0x12a47e5	golang.org/x/tools/internal/gocommand.runCmdContext.func1+0x25	/Users/gopher/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:243

--- FAIL: TestSimultaneousEdits (0.76s)
    --- FAIL: TestSimultaneousEdits/default (0.76s)
        runner.go:369: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /Users/gopher/workdir/tmp/gopls-regtest-3738926842/TestSimultaneousEdits/default: directory not empty
2022-08-04 15:50 linux-386-buster tools@3e0a5031 go@a10afb15 golang.org/x/tools/gopls/internal/regtest/misc.TestSimultaneousEdits (log) 
serve.go:442: debug server listening at http://localhost:44787
serve.go:442: debug server listening at http://localhost:35521
goroutine profile: total 17
2 @ 0x8086258 0x807e5da 0x80b1ae2 0x80eabf7 0x80ebb00 0x80ebae5 0x80f4d12 0x80f4cf2 0x8146055 0x80e64eb 0x819efa4 0x819ef7a 0x819fac4 0x80b6321
#	0x80b1ae1	internal/poll.runtime_pollWait+0x51		/workdir/go/src/runtime/netpoll.go:305
#	0x80eabf6	internal/poll.(*pollDesc).wait+0x36		/workdir/go/src/internal/poll/fd_poll_runtime.go:84
#	0x80ebaff	internal/poll.(*pollDesc).waitRead+0x1df	/workdir/go/src/internal/poll/fd_poll_runtime.go:89
#	0x80ebae4	internal/poll.(*FD).Read+0x1c4			/workdir/go/src/internal/poll/fd_unix.go:167
#	0x80f4d11	os.(*File).read+0x61				/workdir/go/src/os/file_posix.go:31
#	0x80f4cf1	os.(*File).Read+0x41				/workdir/go/src/os/file.go:118
...
#	0x80fba42	os.(*Process).blockUntilWaitable+0x72				/workdir/go/src/os/wait_waitid.go:32
#	0x80f45fd	os.(*Process).wait+0x2d						/workdir/go/src/os/exec_unix.go:22
#	0x819fb8b	os.(*Process).Wait+0x4b						/workdir/go/src/os/exec.go:132
#	0x819fb73	os/exec.(*Cmd).Wait+0x33					/workdir/go/src/os/exec/exec.go:599
#	0x82d45b6	golang.org/x/tools/internal/gocommand.runCmdContext.func1+0x26	/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:243

--- FAIL: TestSimultaneousEdits (0.54s)
    --- FAIL: TestSimultaneousEdits/default (0.54s)
        runner.go:309: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: go command failed (stdout: ) (stderr: go: unlinkat /workdir/tmp/gopls-regtest-760374815/TestSimultaneousEdits/default/gopath/pkg/mod/cache: directory not empty
            ): exit status 1; removing files: <nil>

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 20, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 20, 2022
@rsc
Copy link
Contributor

rsc commented Sep 20, 2022

Stopped.

@rsc rsc closed this as completed Sep 20, 2022
@gopherbot gopherbot changed the title x/tools/gopls/internal/regtest/misc: flaky TestSimultaneousEdits x/tools/gopls/internal/regtest/misc: TestSimultaneousEdits failures Sep 20, 2022
@golang golang locked and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@rsc @gopherbot