Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/internal/regtest/modfile: TestUnusedDiag failures #55177

Closed
gopherbot opened this issue Sep 20, 2022 · 2 comments
Closed

x/tools/gopls/internal/regtest/modfile: TestUnusedDiag failures #55177

gopherbot opened this issue Sep 20, 2022 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && test == "TestUnusedDiag"

Bug automatically created to track these flakes.

— watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2022
@gopherbot
Copy link
Author

gopherbot commented Sep 20, 2022

Found new matching flaky dashboard failures for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && test == "TestUnusedDiag"
2022-07-14 01:47 windows-arm64-10 tools@db8f89b3 go@266c70c2 golang.org/x/tools/gopls/internal/regtest/modfile.TestUnusedDiag (log)
goroutine profile: total 15
2 @ 0x7ff7a3d93b74 0x7ff7a3df7a5c 0x7ff7a3df7890 0x7ff7a3e14660 0x7ff7a3e0e530 0x7ff7a3e0e521 0x7ff7a3e406c0 0x7ff7a3e4b5e4 0x7ff7a3e4b5d9 0x7ff7a3e9b580 0x7ff7a3e37998 0x7ff7a3ef26b4 0x7ff7a3ef2691 0x7ff7a3ef351c 0x7ff7a3dfb404
#	0x7ff7a3df7a5b	syscall.SyscallN+0xeb				C:/workdir/go/src/runtime/syscall_windows.go:557
#	0x7ff7a3df788f	syscall.Syscall6+0x3f				C:/workdir/go/src/runtime/syscall_windows.go:501
#	0x7ff7a3e1465f	syscall.readFile+0x7f				C:/workdir/go/src/syscall/zsyscall_windows.go:1024
#	0x7ff7a3e0e52f	syscall.ReadFile+0x2f				C:/workdir/go/src/syscall/syscall_windows.go:400
#	0x7ff7a3e0e520	syscall.Read+0x20				C:/workdir/go/src/syscall/syscall_windows.go:379
#	0x7ff7a3e406bf	internal/poll.(*FD).Read+0x1af			C:/workdir/go/src/internal/poll/fd_windows.go:427
#	0x7ff7a3e4b5e3	os.(*File).read+0x63				C:/workdir/go/src/os/file_posix.go:31
#	0x7ff7a3e4b5d8	os.(*File).Read+0x58				C:/workdir/go/src/os/file.go:118
...
#	0x7ff7a3df6157	sync.runtime_Semacquire+0x27							C:/workdir/go/src/runtime/sema.go:62
#	0x7ff7a3e0a15f	sync.(*WaitGroup).Wait+0x7f							C:/workdir/go/src/sync/waitgroup.go:139
#	0x7ff7a453730b	golang.org/x/tools/internal/lsp.(*Server).diagnoseSnapshots+0x1cb		C:/workdir/gopath/src/golang.org/x/tools/internal/lsp/diagnostics.go:108
#	0x7ff7a454f257	golang.org/x/tools/internal/lsp.(*Server).processModifications.func1+0x37	C:/workdir/gopath/src/golang.org/x/tools/internal/lsp/text_synchronization.go:300

--- FAIL: TestUnusedDiag (24.36s)
    --- FAIL: TestUnusedDiag/default (17.34s)
        --- FAIL: TestUnusedDiag/default/singleton (13.35s)
            runner.go:348: closing editor: Shutdown: context deadline exceeded
            runner.go:322: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: remove C:\Users\gopher\AppData\Local\Temp\gopls-regtest-277654378\TestUnusedDiag\default\singleton\work\a: The process cannot access the file because it is being used by another process.

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 20, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 20, 2022
@rsc
Copy link
Contributor

rsc commented Sep 20, 2022

Stopped.

@rsc rsc closed this as completed Sep 20, 2022
@gopherbot gopherbot changed the title x/tools/gopls/internal/regtest/modfile: flaky TestUnusedDiag x/tools/gopls/internal/regtest/modfile: TestUnusedDiag failures Sep 20, 2022
@golang golang locked and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Status: Done
Development

No branches or pull requests

2 participants