Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/regtest/modfile: TestMissingDependencyFixes failures #55175

Closed
gopherbot opened this issue Sep 20, 2022 · 2 comments
Closed

x/tools/gopls/internal/regtest/modfile: TestMissingDependencyFixes failures #55175

gopherbot opened this issue Sep 20, 2022 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && test == "TestMissingDependencyFixes"

Bug automatically created to track these flakes.

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2022
@gopherbot
Copy link
Author

gopherbot commented Sep 20, 2022 •
edited

Found new matching flaky dashboard failures for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && test == "TestMissingDependencyFixes"
2022-07-14 01:47 windows-arm64-10 tools@db8f89b3 go@a906d3dd golang.org/x/tools/gopls/internal/regtest/modfile.TestMissingDependencyFixes (log) 
goroutine profile: total 15
2 @ 0x7ff6c7153b74 0x7ff6c71b7a5c 0x7ff6c71b7890 0x7ff6c71d4660 0x7ff6c71ce530 0x7ff6c71ce521 0x7ff6c72006c0 0x7ff6c720b5e4 0x7ff6c720b5d9 0x7ff6c725b580 0x7ff6c71f7998 0x7ff6c72b26b4 0x7ff6c72b2691 0x7ff6c72b351c 0x7ff6c71bb404
#	0x7ff6c71b7a5b	syscall.SyscallN+0xeb				C:/workdir/go/src/runtime/syscall_windows.go:557
#	0x7ff6c71b788f	syscall.Syscall6+0x3f				C:/workdir/go/src/runtime/syscall_windows.go:501
#	0x7ff6c71d465f	syscall.readFile+0x7f				C:/workdir/go/src/syscall/zsyscall_windows.go:1024
#	0x7ff6c71ce52f	syscall.ReadFile+0x2f				C:/workdir/go/src/syscall/syscall_windows.go:400
#	0x7ff6c71ce520	syscall.Read+0x20				C:/workdir/go/src/syscall/syscall_windows.go:379
#	0x7ff6c72006bf	internal/poll.(*FD).Read+0x1af			C:/workdir/go/src/internal/poll/fd_windows.go:427
#	0x7ff6c720b5e3	os.(*File).read+0x63				C:/workdir/go/src/os/file_posix.go:31
#	0x7ff6c720b5d8	os.(*File).Read+0x58				C:/workdir/go/src/os/file.go:118
...
--- FAIL: TestMissingDependencyFixes (29.80s)
    --- FAIL: TestMissingDependencyFixes/nested (17.80s)
        --- FAIL: TestMissingDependencyFixes/nested/singleton (11.93s)
            runner.go:348: closing editor: Shutdown: context deadline exceeded
goroutine profile: total 15
2 @ 0x7ff6c7153b74 0x7ff6c71b7a5c 0x7ff6c71b7890 0x7ff6c71d4660 0x7ff6c71ce530 0x7ff6c71ce521 0x7ff6c72006c0 0x7ff6c720b5e4 0x7ff6c720b5d9 0x7ff6c725b580 0x7ff6c71f7998 0x7ff6c72b26b4 0x7ff6c72b2691 0x7ff6c72b351c 0x7ff6c71bb404
#	0x7ff6c71b7a5b	syscall.SyscallN+0xeb				C:/workdir/go/src/runtime/syscall_windows.go:557
#	0x7ff6c71b788f	syscall.Syscall6+0x3f				C:/workdir/go/src/runtime/syscall_windows.go:501
#	0x7ff6c71d465f	syscall.readFile+0x7f				C:/workdir/go/src/syscall/zsyscall_windows.go:1024
#	0x7ff6c71ce52f	syscall.ReadFile+0x2f				C:/workdir/go/src/syscall/syscall_windows.go:400
...
#	0x7ff6c739773b	golang.org/x/tools/internal/lsp/protocol.ServerHandler.func1+0x6b	C:/workdir/gopath/src/golang.org/x/tools/internal/lsp/protocol/protocol.go:157
#	0x7ff6c7916717	golang.org/x/tools/internal/lsp/lsprpc.handshaker.func1+0x7c7		C:/workdir/gopath/src/golang.org/x/tools/internal/lsp/lsprpc/lsprpc.go:511
#	0x7ff6c737f897	golang.org/x/tools/internal/jsonrpc2.MustReplyHandler.func1+0xf7	C:/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/handler.go:35
#	0x7ff6c73804bf	golang.org/x/tools/internal/jsonrpc2.AsyncHandler.func1.2+0x8f		C:/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/handler.go:103

1 @ 0x7ff6c718c2e4 0x7ff6c719d7f4 0x7ff6c719d7d1 0x7ff6c71b6158 0x7ff6c71ca160 0x7ff6c78f730c 0x7ff6c790f258 0x7ff6c71bb404
#	0x7ff6c71b6157	sync.runtime_Semacquire+0x27							C:/workdir/go/src/runtime/sema.go:62
#	0x7ff6c71ca15f	sync.(*WaitGroup).Wait+0x7f							C:/workdir/go/src/sync/waitgroup.go:139
#	0x7ff6c78f730b	golang.org/x/tools/internal/lsp.(*Server).diagnoseSnapshots+0x1cb		C:/workdir/gopath/src/golang.org/x/tools/internal/lsp/diagnostics.go:108
#	0x7ff6c790f257	golang.org/x/tools/internal/lsp.(*Server).processModifications.func1+0x37	C:/workdir/gopath/src/golang.org/x/tools/internal/lsp/text_synchronization.go:300

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 20, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 20, 2022
@rsc
Copy link
Contributor

rsc commented Sep 20, 2022

Stopped.

@rsc rsc closed this as completed Sep 20, 2022
@gopherbot gopherbot changed the title x/tools/gopls/internal/regtest/modfile: flaky TestMissingDependencyFixes x/tools/gopls/internal/regtest/modfile: TestMissingDependencyFixes failures Sep 20, 2022
@golang golang locked and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@rsc @gopherbot