Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/internal/regtest/modfile: TestGoGetFix failures #55174

Closed
gopherbot opened this issue Sep 20, 2022 · 2 comments
Closed

x/tools/gopls/internal/regtest/modfile: TestGoGetFix failures #55174

gopherbot opened this issue Sep 20, 2022 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && test == "TestGoGetFix"

Bug automatically created to track these flakes.

— watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2022
@gopherbot
Copy link
Author

gopherbot commented Sep 20, 2022

Found new matching flaky dashboard failures for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && test == "TestGoGetFix"
2022-07-14 01:47 windows-arm64-10 tools@db8f89b3 go@4651ebf9 golang.org/x/tools/gopls/internal/regtest/modfile.TestGoGetFix (log)
goroutine profile: total 15
2 @ 0x7ff622d33b74 0x7ff622d97a5c 0x7ff622d97890 0x7ff622db4660 0x7ff622dae530 0x7ff622dae521 0x7ff622de06c0 0x7ff622deb5e4 0x7ff622deb5d9 0x7ff622e3b580 0x7ff622dd7998 0x7ff622e926b4 0x7ff622e92691 0x7ff622e9351c 0x7ff622d9b404
#	0x7ff622d97a5b	syscall.SyscallN+0xeb				C:/workdir/go/src/runtime/syscall_windows.go:557
#	0x7ff622d9788f	syscall.Syscall6+0x3f				C:/workdir/go/src/runtime/syscall_windows.go:501
#	0x7ff622db465f	syscall.readFile+0x7f				C:/workdir/go/src/syscall/zsyscall_windows.go:1024
#	0x7ff622dae52f	syscall.ReadFile+0x2f				C:/workdir/go/src/syscall/syscall_windows.go:400
#	0x7ff622dae520	syscall.Read+0x20				C:/workdir/go/src/syscall/syscall_windows.go:379
#	0x7ff622de06bf	internal/poll.(*FD).Read+0x1af			C:/workdir/go/src/internal/poll/fd_windows.go:427
#	0x7ff622deb5e3	os.(*File).read+0x63				C:/workdir/go/src/os/file_posix.go:31
#	0x7ff622deb5d8	os.(*File).Read+0x58				C:/workdir/go/src/os/file.go:118
...
#	0x7ff622d96157	sync.runtime_Semacquire+0x27							C:/workdir/go/src/runtime/sema.go:62
#	0x7ff622daa15f	sync.(*WaitGroup).Wait+0x7f							C:/workdir/go/src/sync/waitgroup.go:139
#	0x7ff6234d730b	golang.org/x/tools/internal/lsp.(*Server).diagnoseSnapshots+0x1cb		C:/workdir/gopath/src/golang.org/x/tools/internal/lsp/diagnostics.go:108
#	0x7ff6234ef257	golang.org/x/tools/internal/lsp.(*Server).processModifications.func1+0x37	C:/workdir/gopath/src/golang.org/x/tools/internal/lsp/text_synchronization.go:300

--- FAIL: TestGoGetFix (19.67s)
    --- FAIL: TestGoGetFix/default (10.65s)
        --- FAIL: TestGoGetFix/default/singleton (8.57s)
            runner.go:348: closing editor: Shutdown: context deadline exceeded
2022/07/15 17:39:59 cleaning workspace dir: remove C:\Users\gopher\AppData\Local\Temp\gopls-workspace-mod1526731520: The process cannot access the file because it is being used by another process.

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 20, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 20, 2022
@rsc
Copy link
Contributor

rsc commented Sep 20, 2022

Stopped.

@rsc rsc closed this as completed Sep 20, 2022
@gopherbot gopherbot changed the title x/tools/gopls/internal/regtest/modfile: flaky TestGoGetFix x/tools/gopls/internal/regtest/modfile:: TestGoGetFix failures Sep 20, 2022
@gopherbot gopherbot changed the title x/tools/gopls/internal/regtest/modfile:: TestGoGetFix failures x/tools/gopls/internal/regtest/modfile: TestGoGetFix failures Sep 20, 2022
@golang golang locked and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Status: Done
Development

No branches or pull requests

2 participants