Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/internal/regtest/workspace: TestUseGoWork failures #55171

Closed
gopherbot opened this issue Sep 20, 2022 · 4 comments
Closed

x/tools/gopls/internal/regtest/workspace: TestUseGoWork failures #55171

gopherbot opened this issue Sep 20, 2022 · 4 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/workspace" && test == "TestUseGoWork"

Bug automatically created to track these flakes.

— watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2022
@gopherbot
Copy link
Author

gopherbot commented Sep 20, 2022

Found new matching flaky dashboard failures for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/workspace" && test == "TestUseGoWork"
2022-07-14 01:47 darwin-arm64-11 tools@db8f89b3 go@aa802285 golang.org/x/tools/gopls/internal/regtest/workspace.TestUseGoWork (log)
#### Start Gopls Test Logs for "TestUseGoWork/singleton"
[Trace - 17:05:00.169 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"executeCommand":{},"semanticTokens":{},"codeLens":{},"inlineValue":{},"inlayHint":{},"configuration":true},"textDocument":{"synchronization":{},"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]},"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null}},"completionItemKind":{},"completionList":{}},"hover":{},"signatureHelp":{"signatureInformation":{"parameterInformation":{}}},"declaration":{},"definition":{},"typeDefinition":{},"implementation":{},"references":{},"documentHighlight":{},"documentSymbol":{"symbolKind":{},"tagSupport":{"valueSet":null}},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}},"resolveSupport":{"properties":null}},"codeLens":{},"documentLink":{},"colorProvider":{},"formatting":{},"rangeFormatting":{},"onTypeFormatting":{},"rename":{},"foldingRange":{},"selectionRange":{},"publishDiagnostics":{"tagSupport":{"valueSet":null}},"callHierarchy":{},"semanticTokens":{"requests":{"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null},"linkedEditingRange":{},"moniker":{},"typeHierarchy":{},"inlineValue":{},"inlayHint":{"resolveSupport":{"properties":null}}},"window":{"workDoneProgress":true,"showMessage":{"messageActionItem":{}},"showDocument":{"support":false}},"general":{"staleRequestSupport":{"cancel":false,"retryOnContentModified":null},"regularExpressions":{"engine":""},"markdown":{"parser":""}}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/buildlet/tmp/gopls-regtest-1894830730/TestUseGoWork/singleton/gopath","GOPROXY":"file:///tmp/buildlet/tmp/gopls-regtest-1894830730/TestUseGoWork/singleton/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/buildlet/tmp/gopls-regtest-1894830730/TestUseGoWork/singleton/work","name":"work"}]}


[Trace - 17:05:00.169 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."],"completionItem":{}},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"documentOnTypeFormattingProvider":{"firstTriggerCharacter":""},"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}},"inlayHintProvider":{}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel aa802285265ac370f7ce62299e54ec84635b794e\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 17:05:00.169 PM] Sending notification 'initialized'.
...
--- FAIL: TestUseGoWork (569.81s)
    --- FAIL: TestUseGoWork/singleton (569.81s)
        workspace_test.go:788: waiting on:
            Unmet: empty or no diagnostics for "modb/go.mod"

            err:context deadline exceeded

            state:
            #### log messages (see RPC logs for full text):
            	Info: "2022/07/14 17:05:00 go env for /tmp/buildlet/tmp/g...
...
            	Load: 0.00
            #### completed work:
            	Running go get: 1
            	diagnosing changed files: 2
            	Load: 7
            	Setting up workspace: 1
            	diagnosing initial workspace load: 1
            	diagnosing opened files: 5
            	diagnosing files changed on disk: 2
        runner.go:348: closing editor: Shutdown: context deadline exceeded

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 20, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 20, 2022
@rsc
Copy link
Contributor

rsc commented Sep 20, 2022

Stopped.

@rsc rsc closed this as completed Sep 20, 2022
@gopherbot gopherbot changed the title x/tools/gopls/internal/regtest/workspace: flaky TestUseGoWork x/tools/gopls/internal/regtest/workspace:: TestUseGoWork failures Sep 20, 2022
@gopherbot gopherbot changed the title x/tools/gopls/internal/regtest/workspace:: TestUseGoWork failures x/tools/gopls/internal/regtest/workspace: TestUseGoWork failures Sep 20, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/workspace" && test == "TestUseGoWork"
2023-03-14 19:57 linux-s390x-ibm tools@c17e55ec go@9ae97f8b x/tools/gopls/internal/regtest/workspace.TestUseGoWork (log)
#### Start Gopls Test Logs for "TestUseGoWork/default"
[Trace - 20:51:30.627 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-1394070900/TestUseGoWork/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-1394070900/TestUseGoWork/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-1394070900/TestUseGoWork/default/work","name":"work"}]}


[Trace - 20:51:30.627 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 9ae97f8b8b07c63d354ac41cd37771d87c679df7\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 20:51:30.628 PM] Sending notification 'initialized'.
...
--- FAIL: TestUseGoWork (1.03s)
    --- FAIL: TestUseGoWork/default (1.03s)
        env.go:345: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 2 time(s)" is met, must have:
            any diagnostics at the first position matching `x` in "modb/b/b.go"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	moda/a/a.go (version 1):
            		(7, 5) [compiler]: x declared and not used
            		(8, 5) [compiler]: b.Hello() (no value) used as value
            	/data/golang/workdir/tmp/gopls-regtest-1394070900/TestUseGoWork/default/gopath/pkg/mod/b.com@v1.2.3/b/b.go (version 1):

            #### outstanding work:
            #### completed work:
            	Setting up workspace: 1
            	diagnosing opened files: 2
            	diagnosing initial workspace load: 1

watchflakes

@gopherbot gopherbot reopened this Mar 15, 2023
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.12.0 Mar 18, 2023
@findleyr
Copy link
Contributor

Unmeetable: once "All of:\ncompleted work "diagnosing opened files" at least 2 time(s)" is met, must have:
any diagnostics at the first position matching x in "modb/b/b.go"

The regtest is missing a "didChangeWatchedFile" notification. Unless this repeats itself, I'm going to chalk this up to bizarre builder FS behavior, and avoid investing time in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Status: Done
Development

No branches or pull requests

3 participants