Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/perf: regressions dashboard broken: panic: index out of range #55158

Open
prattmic opened this issue Sep 19, 2022 · 1 comment
Open

x/perf: regressions dashboard broken: panic: index out of range #55158

prattmic opened this issue Sep 19, 2022 · 1 comment
Assignees
@prattmic
Labels
Builders x/build issues (builders, bots, dashboards) compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@prattmic
Copy link
Member

https://perf.golang.org/dashboard/?benchmark=regressions is broken due to a panic in the handler:

2022/09/19 21:52:14 http2: panic serving 10.102.129.129:15437: runtime error: index out of range [341] with length 341
goroutine 2971853 [running]:
net/http.(*http2serverConn).runHandler.func1()
 /usr/local/go/src/net/http/h2_bundle.go:5896 +0x125
panic({0xeb82c0, 0xc0004128b8})
 /usr/local/go/src/runtime/panic.go:838 +0x207
golang.org/x/build/perf/app.renameBenchmarksWithRegressions({0xc0000a8700, 0xcf, 0xcf?}, 0xb7782e?)
 /app/perf/app/dashboard.go:394 +0x4bd
golang.org/x/build/perf/app.groupBenchmarkResults(0xf6c917?, 0x1)
 /app/perf/app/dashboard.go:426 +0x65
golang.org/x/build/perf/app.fetchAllBenchmarks({0x10a8b10, 0xc000b2b3c0}, {0x10a8d78, 0xc0007345c0}, 0x48?, {0x450797?, 0x23?, 0x1b8e440?}, {0xc0c25702dd2d545a, 0x1e0f2939c9606, ...})
 /app/perf/app/dashboard.go:272 +0x1a5
2022-09-19 14:52:14.146 PDT
...

I don't immediately see why this is occurring, but perhaps we have 2 benchmarks with the same name, leading to a collision in the regressions map. I can take a longer look later.

cc @dr2chase @mknyszek
@prattmic prattmic added the Builders x/build issues (builders, bots, dashboards) label Sep 19, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 19, 2022
@prattmic prattmic changed the title x/perf: regressions dashboard broken x/perf: regressions dashboard broken: panic: index out of range Sep 19, 2022
@cherrymui cherrymui added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2022
@prattmic
Copy link
Member Author

This has actually resolved itself, even when extending the view to 90 days, which is odd.

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prattmic prattmic

Labels
Builders x/build issues (builders, bots, dashboards) compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Compiler / Runtime
Status: Todo
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@prattmic @gopherbot @cherrymui