Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: codelens not working at tip #55155

Closed
suzmue opened this issue Sep 19, 2022 · 1 comment
Closed

x/tools/gopls: codelens not working at tip #55155

suzmue opened this issue Sep 19, 2022 · 1 comment
Assignees
@suzmue
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.10.0

Comments

@suzmue
Copy link
Contributor

suzmue commented Sep 19, 2022

codelensProvider field in initializeProvider is no longer being set, so the client does not know to request codelenses. I think this is a result of updates to tsprotocol.go

cc @pjweinb
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 19, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 19, 2022
@gopherbot
Copy link

Change https://go.dev/cl/431837 mentions this issue: gopls: set codelensProvider in initialize response

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.10.0 Sep 19, 2022
@suzmue suzmue self-assigned this Sep 19, 2022
@golang golang locked and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@suzmue suzmue

Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.10.0
Development

No branches or pull requests
3 participants
@suzmue @gopherbot @findleyr