Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: typebits.Set: invalid initial alignment: type Peer has alignment 8, but offset is 4 [1.19 backport] #55152

Closed
gopherbot opened this issue Sep 19, 2022 · 5 comments
Closed

cmd/compile: typebits.Set: invalid initial alignment: type Peer has alignment 8, but offset is 4 [1.19 backport] #55152

gopherbot opened this issue Sep 19, 2022 · 5 comments
Assignees
@cuonglm
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.19.2

Comments

@gopherbot
Copy link
Contributor

@cherrymui requested issue #54991 to be considered for backport to the next 1.19 minor release.

SGTM for backporting.

@gopherbot please backport this to Go 1.19 . This causes valid program fail to compile.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 19, 2022
@gopherbot gopherbot mentioned this issue Sep 19, 2022
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Sep 19, 2022
@gopherbot gopherbot added this to the Go1.19.2 milestone Sep 19, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/431895 mentions this issue: [release-branch.go1.19] cmd/compile/internal/typebits: relax alignment check

@mknyszek mknyszek moved this to All-But-Submitted in Go Compiler / Runtime Sep 19, 2022
@laboger
Copy link
Contributor

laboger commented Sep 20, 2022

This change causes build errors on ppc64le on master with Openshift. Please hold off on backporting. I have asked the testers to open an issue with reproducer information.

@mkumatag
Copy link

This change causes build errors on ppc64le on master with Openshift. Please hold off on backporting. I have asked the testers to open an issue with reproducer information.

#55254 here is the issue created

@cuonglm
Copy link
Member

cuonglm commented Sep 20, 2022

Not related to this issue, since when the last known good commit is 7db923f, which was after this one.

@cherrymui cherrymui added the CherryPickApproved Used during the release process for point releases label Sep 21, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Sep 21, 2022
@gopherbot
Copy link
Contributor Author

Closed by merging 2614985 to release-branch.go1.19.

Repository owner moved this from All-But-Submitted to Done in Go Compiler / Runtime Sep 21, 2022
gopherbot pushed a commit that referenced this issue Sep 21, 2022
@cuonglm @cherrymui
[release-branch.go1.19] cmd/compile/internal/typebits: relax alignmen…
2614985 
…t check

Now we have 8-byte alignment types on 32-bit system, so in some rare
case, e.g, generated wrapper for embedded interface, the function
argument may need more than 4 byte alignment. We could pad somehow, but
this is a rare case which makes it hard to ensure that we've got it right.

So relaxing the check for argument and return value region of the stack.

Fixes #55152

Change-Id: I34986e17a920254392a39439ad3dcb323da2ea8d
Reviewed-on: https://go-review.googlesource.com/c/go/+/431098
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/431895
zmb3 added a commit to gravitational/teleport that referenced this issue Sep 30, 2022
@zmb3
Revert "Remove [direct] dependency on go.uber.org/atomic (#16884)"
3062297 
This reverts commit 4f3aa9a.

We're unable to build for 32-bit Linux due to
golang/go#55152,
which looks like it will be fixed with Go 1.19.2 next week.

We'll re-evaluate with the next Go release and reintroduce this change
as soon as we can.
@zmb3 zmb3 mentioned this issue Sep 30, 2022
Merged
zmb3 added a commit to gravitational/teleport that referenced this issue Sep 30, 2022
@zmb3
Revert "Remove [direct] dependency on go.uber.org/atomic (#16884)" (#…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
09de0ba 
…16918)

This reverts commit 4f3aa9a.

We're unable to build for 32-bit Linux due to
golang/go#55152,
which looks like it will be fixed with Go 1.19.2 next week.

We'll re-evaluate with the next Go release and reintroduce this change
as soon as we can.
bradfitz pushed a commit to tailscale/go that referenced this issue Oct 5, 2022
@cuonglm @bradfitz
[release-branch.go1.19] cmd/compile/internal/typebits: relax alignmen…
666108b 
…t check

Now we have 8-byte alignment types on 32-bit system, so in some rare
case, e.g, generated wrapper for embedded interface, the function
argument may need more than 4 byte alignment. We could pad somehow, but
this is a rare case which makes it hard to ensure that we've got it right.

So relaxing the check for argument and return value region of the stack.

Fixes golang#55152

Change-Id: I34986e17a920254392a39439ad3dcb323da2ea8d
Reviewed-on: https://go-review.googlesource.com/c/go/+/431098
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/431895
bradfitz pushed a commit to tailscale/go that referenced this issue Oct 5, 2022
@cuonglm @bradfitz
[release-branch.go1.19] cmd/compile/internal/typebits: relax alignmen…
cf25257 
…t check

Now we have 8-byte alignment types on 32-bit system, so in some rare
case, e.g, generated wrapper for embedded interface, the function
argument may need more than 4 byte alignment. We could pad somehow, but
this is a rare case which makes it hard to ensure that we've got it right.

So relaxing the check for argument and return value region of the stack.

Fixes golang#55152

Change-Id: I34986e17a920254392a39439ad3dcb323da2ea8d
Reviewed-on: https://go-review.googlesource.com/c/go/+/431098
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/431895
bradfitz pushed a commit to tailscale/go that referenced this issue Oct 5, 2022
@cuonglm @bradfitz
[release-branch.go1.19] cmd/compile/internal/typebits: relax alignmen…
f66827f 
…t check

Now we have 8-byte alignment types on 32-bit system, so in some rare
case, e.g, generated wrapper for embedded interface, the function
argument may need more than 4 byte alignment. We could pad somehow, but
this is a rare case which makes it hard to ensure that we've got it right.

So relaxing the check for argument and return value region of the stack.

Fixes golang#55152

Change-Id: I34986e17a920254392a39439ad3dcb323da2ea8d
Reviewed-on: https://go-review.googlesource.com/c/go/+/431098
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/431895
@golang golang locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cuonglm cuonglm

Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.19.2
Development

No branches or pull requests
5 participants
@cuonglm @gopherbot @laboger @mkumatag @cherrymui