Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types: no way to construct the signature of append(s, "string"...) via the API [1.18 backport] #55148

Closed
gopherbot opened this issue Sep 19, 2022 · 2 comments
Closed

go/types: no way to construct the signature of append(s, "string"...) via the API [1.18 backport] #55148

gopherbot opened this issue Sep 19, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.18.7

Comments

@gopherbot
Copy link

@findleyr requested issue #55030 to be considered for backport to the next 1.18 minor release.

@gopherbot please consider this for backport to 1.18 and 1.19, it is a bug that NewSignatureType panics on valid signatures.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 19, 2022
@gopherbot gopherbot mentioned this issue Sep 19, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.7 milestone Sep 19, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/431915 mentions this issue: [release-branch.go1.18] go/types, types2: allow (string...) signature with NewSignatureType

@cherrymui cherrymui added the CherryPickApproved Used during the release process for point releases label Sep 21, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Sep 21, 2022
@gopherbot
Copy link
Author

Closed by merging e40a130 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Sep 21, 2022
@griesemer @cherrymui
[release-branch.go1.18] go/types, types2: allow (string...) signature…
e40a130 
… with NewSignatureType

Includes cases where the core type of the variadic parameter is
a slice or bytestring. Permits a client to create the signature
for various instantiations of append.

Fixes #55148.

Change-Id: I0f4983eb00c088cbe1d87954ee0b2df0ccc3bc49
Reviewed-on: https://go-review.googlesource.com/c/go/+/430455
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/431915
@golang golang locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.18.7
Development

No branches or pull requests
2 participants
@gopherbot @cherrymui