Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: package removal request for ktbs.dev/teler #55118

Closed
dwisiswant0 opened this issue Sep 17, 2022 · 7 comments
Closed

x/pkgsite: package removal request for ktbs.dev/teler #55118

dwisiswant0 opened this issue Sep 17, 2022 · 7 comments
Labels
FrozenDueToAge pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Milestone
Unreleased

Comments

@dwisiswant0
Copy link

dwisiswant0 commented Sep 17, 2022 •
edited

What is the path of the package that you would like to have removed?

ktbs.dev/teler

Are you the owner of this package?

Yes.

What is the reason that you could not retract this package instead?

I want to delete all the versions listed instead of retracting them one by one. For several reasons:

  1. Custom domain is not configured (and maintained) anymore, and
  2. Replace it with a new custom domain.

Having trouble doing reason(2), because https://pkg.go.dev/teler.app is redirected to an old custom domain.

$ go list -m -json -v teler.app@latest
{
	"Path": "teler.app",
	"Version": "v1.2.2",
	"Query": "latest",
	"Time": "2021-04-01T23:06:52Z",
	"Dir": "/home/dw1/.go/pkg/mod/teler.app@v1.2.2",
	"GoMod": "/home/dw1/.go/pkg/mod/cache/download/teler.app/@v/v1.2.2.mod",
	"GoVersion": "1.14"
}

But deps.dev listing it correctly.

On a special note, I don't want to change the codebase directory structure like moving files under the new /v2 path.
@gopherbot gopherbot added this to the Unreleased milestone Sep 17, 2022
@seankhliao seankhliao added the pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package label Sep 17, 2022
@seankhliao
Copy link
Member

note teler.app needs a major version suffix in its module path (but not necessarily directory structure) as its tags are v2+

@dwisiswant0
Copy link
Author

dwisiswant0 commented Sep 17, 2022 •
edited

note teler.app needs a major version suffix in its module path (but not necessarily directory structure) as its tags are v2+

Can you please elaborate? So that means I have to change the module path (to teler.app/v2) in go.mod? Got it.

So after you guys delete the package for my old custom domain from pkg.go.dev and list the new custom domain, it will be ok to do go install teler.app@latest right?

@seankhliao
Copy link
Member

No.
Removing it from pkgsite only hides the generated documentation.
If go install doesn't work now, it still won't work if we hide the documentation. It's a configuration issue on your site and/or module.

@dwisiswant0
Copy link
Author

Currently not working because I think the version is not listed on pkg.go.dev. Correct me if I'm wrong.

@seankhliao
Copy link
Member

pkg.go.dev does not affect the go tool

@findleyr
Copy link
Contributor

Following @seankhliao's clarification (#55118 (comment)), do you still want us to remove from pkg.go.dev, bearing in mind that it will have no effect on the go tool?

@dwisiswant0
Copy link
Author

Given such evidence, I will close this issue until I can resolve the current situation. Thanks, @seankhliao & @findleyr.

@golang golang locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@gopherbot @seankhliao @dwisiswant0 @findleyr