Skip to content

cmd/link: new darwin linker warning on -pagezero_size and -no_pie deprecation [1.19 backport] #55114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Sep 16, 2022 · 3 comments
Closed

cmd/link: new darwin linker warning on -pagezero_size and -no_pie deprecation [1.19 backport] #55114

gopherbot opened this issue Sep 16, 2022 · 3 comments
Assignees
@thanm @cherrymui
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.19.2

Comments

@gopherbot
Copy link
Contributor

@cherrymui requested issue #55112 to be considered for backport to the next 1.19 minor release.

@gopherbot please backport this to previous releases. Thanks.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 16, 2022
@gopherbot gopherbot mentioned this issue Sep 16, 2022
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Sep 16, 2022
@gopherbot gopherbot added this to the Go1.19.2 milestone Sep 16, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/431515 mentions this issue: [release-branch.go1.19] cmd/link: stop passing -pagezero_size to darwin linker

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/431517 mentions this issue: [release-branch.go1.19] cmd/link: suppress -no_pie deprecation warning on darwin

@mknyszek mknyszek moved this to In Progress in Go Compiler / Runtime Sep 19, 2022
@cherrymui cherrymui added the CherryPickApproved Used during the release process for point releases label Sep 21, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Sep 21, 2022
@gopherbot
Copy link
Contributor Author

Closed by merging 064f34f to release-branch.go1.19.

Repository owner moved this from In Progress to Done in Go Compiler / Runtime Sep 21, 2022
gopherbot pushed a commit that referenced this issue Sep 21, 2022
@cherrymui
[release-branch.go1.19] cmd/link: stop passing -pagezero_size to darw…
064f34f 
…in linker

We added -pagezero_size in CL 72730, where it was intented for iOS.
The current code passes it only on macOS/AMD64 instead. It is not
really necessary there. Also, the new darwin linker starts to emit
a warning about deprecation of the flag. Stop passing it.

For #55114.
Updates #55112, #54482.

Change-Id: If9db7a1645c37d4284e48f075856912df8d8c1a0
Reviewed-on: https://go-review.googlesource.com/c/go/+/430936
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
(cherry picked from commit 5231ba2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/431515
Reviewed-by: Austin Clements <austin@google.com>
gopherbot pushed a commit that referenced this issue Sep 21, 2022
@cherrymui
[release-branch.go1.19] cmd/link: suppress -no_pie deprecation warnin…
11728b3 
…g on darwin

Apparently the new darwin linker starts to emit a warning about
-no_pie deprecation. Maybe we want to switch to PIE by default.
For now, suppress the warning. This also makes it easier for
backporting to previous releases.

Fixes #55114.
Updates #55112, #54482.

Change-Id: I1a3b74c237a9d00ec3b030fc3a9940a31e5cd37e
Reviewed-on: https://go-review.googlesource.com/c/go/+/430937
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 706d84f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/431517
bradfitz pushed a commit to tailscale/go that referenced this issue Oct 5, 2022
@cherrymui @bradfitz
[release-branch.go1.19] cmd/link: stop passing -pagezero_size to darw…

Verified

This commit was signed with the committer’s verified signature.
bradfitz Brad Fitzpatrick
SSH Key Fingerprint: kpIRFmgdew7v0c3tuW9uYSWyYv0WW9j5hzBZwzkn0/U
Verified
Learn about vigilant mode
08f29e8 
…in linker

We added -pagezero_size in CL 72730, where it was intented for iOS.
The current code passes it only on macOS/AMD64 instead. It is not
really necessary there. Also, the new darwin linker starts to emit
a warning about deprecation of the flag. Stop passing it.

For golang#55114.
Updates golang#55112, golang#54482.

Change-Id: If9db7a1645c37d4284e48f075856912df8d8c1a0
Reviewed-on: https://go-review.googlesource.com/c/go/+/430936
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
(cherry picked from commit 5231ba2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/431515
Reviewed-by: Austin Clements <austin@google.com>
bradfitz pushed a commit to tailscale/go that referenced this issue Oct 5, 2022
@cherrymui @bradfitz
[release-branch.go1.19] cmd/link: suppress -no_pie deprecation warnin…

Verified

This commit was signed with the committer’s verified signature.
bradfitz Brad Fitzpatrick
SSH Key Fingerprint: kpIRFmgdew7v0c3tuW9uYSWyYv0WW9j5hzBZwzkn0/U
Verified
Learn about vigilant mode
0682cd6 
…g on darwin

Apparently the new darwin linker starts to emit a warning about
-no_pie deprecation. Maybe we want to switch to PIE by default.
For now, suppress the warning. This also makes it easier for
backporting to previous releases.

Fixes golang#55114.
Updates golang#55112, golang#54482.

Change-Id: I1a3b74c237a9d00ec3b030fc3a9940a31e5cd37e
Reviewed-on: https://go-review.googlesource.com/c/go/+/430937
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 706d84f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/431517
bradfitz pushed a commit to tailscale/go that referenced this issue Oct 5, 2022
@cherrymui @bradfitz
[release-branch.go1.19] cmd/link: stop passing -pagezero_size to darw…

Verified

This commit was signed with the committer’s verified signature.
bradfitz Brad Fitzpatrick
SSH Key Fingerprint: kpIRFmgdew7v0c3tuW9uYSWyYv0WW9j5hzBZwzkn0/U
Verified
Learn about vigilant mode
4019038 
…in linker

We added -pagezero_size in CL 72730, where it was intented for iOS.
The current code passes it only on macOS/AMD64 instead. It is not
really necessary there. Also, the new darwin linker starts to emit
a warning about deprecation of the flag. Stop passing it.

For golang#55114.
Updates golang#55112, golang#54482.

Change-Id: If9db7a1645c37d4284e48f075856912df8d8c1a0
Reviewed-on: https://go-review.googlesource.com/c/go/+/430936
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
(cherry picked from commit 5231ba2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/431515
Reviewed-by: Austin Clements <austin@google.com>
bradfitz pushed a commit to tailscale/go that referenced this issue Oct 5, 2022
@cherrymui @bradfitz
[release-branch.go1.19] cmd/link: suppress -no_pie deprecation warnin…

Verified

This commit was signed with the committer’s verified signature.
bradfitz Brad Fitzpatrick
SSH Key Fingerprint: kpIRFmgdew7v0c3tuW9uYSWyYv0WW9j5hzBZwzkn0/U
Verified
Learn about vigilant mode
be51b97 
…g on darwin

Apparently the new darwin linker starts to emit a warning about
-no_pie deprecation. Maybe we want to switch to PIE by default.
For now, suppress the warning. This also makes it easier for
backporting to previous releases.

Fixes golang#55114.
Updates golang#55112, golang#54482.

Change-Id: I1a3b74c237a9d00ec3b030fc3a9940a31e5cd37e
Reviewed-on: https://go-review.googlesource.com/c/go/+/430937
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 706d84f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/431517
bradfitz pushed a commit to tailscale/go that referenced this issue Oct 5, 2022
@cherrymui @bradfitz
[release-branch.go1.19] cmd/link: stop passing -pagezero_size to darw…
9d7457f 
…in linker

We added -pagezero_size in CL 72730, where it was intented for iOS.
The current code passes it only on macOS/AMD64 instead. It is not
really necessary there. Also, the new darwin linker starts to emit
a warning about deprecation of the flag. Stop passing it.

For golang#55114.
Updates golang#55112, golang#54482.

Change-Id: If9db7a1645c37d4284e48f075856912df8d8c1a0
Reviewed-on: https://go-review.googlesource.com/c/go/+/430936
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
(cherry picked from commit 5231ba2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/431515
Reviewed-by: Austin Clements <austin@google.com>
bradfitz pushed a commit to tailscale/go that referenced this issue Oct 5, 2022
@cherrymui @bradfitz
[release-branch.go1.19] cmd/link: suppress -no_pie deprecation warnin…
71093f0 
…g on darwin

Apparently the new darwin linker starts to emit a warning about
-no_pie deprecation. Maybe we want to switch to PIE by default.
For now, suppress the warning. This also makes it easier for
backporting to previous releases.

Fixes golang#55114.
Updates golang#55112, golang#54482.

Change-Id: I1a3b74c237a9d00ec3b030fc3a9940a31e5cd37e
Reviewed-on: https://go-review.googlesource.com/c/go/+/430937
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 706d84f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/431517
@golang golang locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thanm thanm

@cherrymui cherrymui

Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.19.2
Development

No branches or pull requests
3 participants
@gopherbot @thanm @cherrymui