Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: hash: permit usage of encoding/binary package #55104

Closed
ErikPelli opened this issue Sep 16, 2022 · 5 comments
Closed

proposal: hash: permit usage of encoding/binary package #55104

ErikPelli opened this issue Sep 16, 2022 · 5 comments

Comments

@ErikPelli
Copy link
Contributor

In the pull request #55068 it turned out that the package hash must not depend on encoding/binary.
In my opinion, if this was allowed, the code would be cleaner (I recommend to see the proposed changes in the PR) and the practical difference would not be much, since encoding/binary has little code in it that does what is needed.

Furthermore, this package is already used as a replacement for the append/put uint32/64 functions in the crypto package.
I therefore propose to allow the use of encoding/binary also in the hash package and avoid code duplication.

@gopherbot gopherbot added this to the Proposal milestone Sep 16, 2022
@dsnet
Copy link
Member

dsnet commented Sep 16, 2022

I don't think this needs to be a proposal. At the end of the day, the reason why we can't use encoding/binary in a number of places is due to: #54097.

@rsc
Copy link
Contributor

rsc commented Sep 28, 2022

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

@rsc
Copy link
Contributor

rsc commented Oct 5, 2022

As Joe noted, this is not something we can do.

@rsc
Copy link
Contributor

rsc commented Oct 12, 2022

Based on the discussion above, this proposal seems like a likely decline.
— rsc for the proposal review group

@rsc
Copy link
Contributor

rsc commented Oct 20, 2022

No change in consensus, so declined.
— rsc for the proposal review group

@rsc rsc closed this as completed Oct 20, 2022
@golang golang locked and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants