Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vuln: GetByModule for a local source client breaks standard library pages on pkgsite #55088

Closed
jamalc opened this issue Sep 15, 2022 · 2 comments
Closed

x/vuln: GetByModule for a local source client breaks standard library pages on pkgsite #55088

jamalc opened this issue Sep 15, 2022 · 2 comments
Assignees
@zpavlinovic
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. x/vuln
Milestone
Unreleased

Comments

@jamalc
Copy link

jamalc commented Sep 15, 2022

What did you do?

Ran golang.org/x/pkgsite/cmd/pkgsite with `GO_DISCOVERY_VULN_DB="file://<vulndb_mock>"

What did you expect to see?

No errors on standard library pages.

What did you see instead?

Screen Shot 2022-09-15 at 11 08 19 AM
@jamalc jamalc added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Sep 15, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 15, 2022
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 9, 2023
@zpavlinovic zpavlinovic self-assigned this Feb 8, 2024
@zpavlinovic zpavlinovic added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Feb 8, 2024
@zpavlinovic
Copy link
Contributor

I believe GetByModule is obsolete now. Is this issue still present?

@zpavlinovic
Copy link
Contributor

The issue seems to be gone. The pkgsite has its own vuln db client that handles this well now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zpavlinovic zpavlinovic

Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. x/vuln
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@cagedmantis @zpavlinovic @gopherbot @jamalc @jba