Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log/syslog: TestWrite failures with empty Info #55071

Open
bcmills opened this issue Sep 14, 2022 · 8 comments
Open

log/syslog: TestWrite failures with empty Info #55071

bcmills opened this issue Sep 14, 2022 · 8 comments
Assignees
@mengzhuo
Labels
help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 14, 2022 •
edited by rsc 

#!watchflakes
post <- pkg == "log/syslog" && test == "TestWrite"

--- FAIL: TestWrite (1.83s)
    syslog_test.go:335: s.Info() = '""', didn't match '"<11>%s %s syslog_test[%d]: write test\n"' (0 unexpected EOF)
FAIL
FAIL	log/syslog	2.690s

greplogs -l -e 'FAIL: TestWrite.*(?:\n\s+.*)*s\.Info\(\) = '\''""'\' --since=2022-01-01
2022-09-07T16:00:20-7033275/linux-amd64-wsl
2022-06-17T21:35:36-d42a488/netbsd-arm64-bsiegert
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 14, 2022
@bcmills bcmills added this to the Backlog milestone Sep 14, 2022
@bcmills bcmills mentioned this issue Sep 14, 2022
Closed
@bcmills
Copy link
Contributor Author

bcmills commented Sep 15, 2022

It appears that both of the run helpers for this test are setting arbitrary deadlines and swallowing errors:
https://cs.opensource.google/go/go/+/master:src/log/syslog/syslog_test.go;l=30-41;drc=f78efc0178d51c02beff8a8203910dc0a9c6e953
https://cs.opensource.google/go/go/+/master:src/log/syslog/syslog_test.go;l=70-78;drc=f78efc0178d51c02beff8a8203910dc0a9c6e953

Probably a good start would be to eliminate the arbitrary deadlines and at least emit the errors to the test log.

@mengzhuo mengzhuo self-assigned this Sep 15, 2022
@bcmills bcmills mentioned this issue Sep 20, 2022
Closed
@gopherbot
Copy link

Found new matching dashboard test flakes for:

#!watchflakes
post <- pkg == "log/syslog" && test == "TestWrite"
2022-09-07 16:00 linux-amd64-wsl go@7033275e log/syslog.TestWrite (log) 
--- FAIL: TestWrite (1.83s)
    syslog_test.go:335: s.Info() = '""', didn't match '"<11>%s %s syslog_test[%d]: write test\n"' (0 unexpected EOF)

— watchflakes

@gopherbot
Copy link

Change https://go.dev/cl/451855 mentions this issue: log/syslog: add log when deadline exceeded

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "log/syslog" && test == "TestWrite"
2023-01-20 21:55 freebsd-arm-paulzhol go@27b6ace2 log/syslog.TestWrite (log) 
--- FAIL: TestWrite (8.87s)
    syslog_test.go:335: s.Info() = '""', didn't match '"<11>%s %s syslog_test[%d]: write test 2\n"' (0 unexpected EOF)

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "log/syslog" && test == "TestWrite"
2023-04-11 22:42 darwin-amd64-10_15 go@bc5b1948 log/syslog.TestWrite (log) 
--- FAIL: TestWrite (1.26s)
    syslog_test.go:335: s.Info() = '"<11>2023-04-11T18:54:01-04:00 Gophers-iMac-Pro-2.local syslog_test[6558]: write test\n"', didn't match '"<11>%s %s syslog_test[%d]: write test\n"' (3 %!s(<nil>))
    syslog_test.go:335: s.Info() = '"<11>2023-04-11T18:54:01-04:00 Gophers-iMac-Pro-2.local syslog_test[6558]: write test 2\n"', didn't match '"<11>%s %s syslog_test[%d]: write test 2\n"' (3 %!s(<nil>))

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "log/syslog" && test == "TestWrite"
2023-04-27 21:12 solaris-amd64-oraclerel go@635839a1 log/syslog.TestWrite (log) 
--- FAIL: TestWrite (1.49s)
    syslog_test.go:338: s.Info() = '""', didn't match '"<11>%s %s syslog_test[%d]: write test\n"' (0 unexpected EOF)

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "log/syslog" && test == "TestWrite"
2023-08-17 21:10 darwin-amd64-10_15 go@b4636682 log/syslog.TestWrite (log) 
--- FAIL: TestWrite (1.26s)
    syslog_test.go:335: s.Info() = '"<11>2023-08-18T00:55:10-04:00 Gophers-iMac-Pro-2.local syslog_test[7283]: write test 2\n"', didn't match '"<11>%s %s syslog_test[%d]: write test 2\n"' (3 %!s(<nil>))

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "log/syslog" && test == "TestWrite"
2023-10-11 20:23 dragonfly-amd64-622 go@eff7aef4 log/syslog.TestWrite (log) 
--- FAIL: TestWrite (1.35s)
    syslog_test.go:338: s.Info() = '""', didn't match '"<11>%s %s syslog_test[%d]: write test 2\n"' (0 unexpected EOF)

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mengzhuo mengzhuo

Labels
help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: Active
Milestone
Backlog
Development

No branches or pull requests
3 participants
@mengzhuo @bcmills @gopherbot