Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/regtest/modfile: TestUnknownRevision failure with All files must be saved first #55070

Closed
bcmills opened this issue Sep 14, 2022 · 19 comments
Closed

x/tools/gopls/internal/regtest/modfile: TestUnknownRevision failure with All files must be saved first #55070

bcmills opened this issue Sep 14, 2022 · 19 comments
Assignees
@findleyr
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 14, 2022 •
edited by rsc 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && 
        test == "TestUnknownRevision" && `All files must be saved first`

greplogs -l -e 'FAIL: TestUnknownRevision.*(?:\n\s+.*)*All files must be saved first' --since=2022-02-01
2022-09-07T18:17:13-3ee1710-dfdf551/linux-s390x-ibm
2022-09-07T16:39:44-dd1bab2-027ff3f/linux-s390x-ibm
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 14, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 14, 2022
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 14, 2022
@bcmills bcmills mentioned this issue Sep 14, 2022
Closed
@findleyr findleyr self-assigned this Sep 14, 2022
@findleyr
Copy link
Contributor

I see the race in this test: the test may advance to applying code actions before changes are processed (because there is both a didChange and didSave notification being processed, and we proceed once either of them is done, not both).

I have an in-progress improvement to our expectations that should make it easy to fix this.

@findleyr findleyr mentioned this issue Sep 20, 2022
Closed
@gopherbot
Copy link

Found new matching dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && 
        test == "TestUnknownRevision" && `All files must be saved first`
2022-09-07 16:01 linux-s390x-ibm tools@dd1bab2d go@027ff3f4 x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/nested/default"
[Trace - 14:11:09.737 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"executeCommand":{},"semanticTokens":{},"codeLens":{},"inlineValue":{},"inlayHint":{},"configuration":true},"textDocument":{"synchronization":{},"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]},"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null}},"completionItemKind":{},"completionList":{}},"hover":{},"signatureHelp":{"signatureInformation":{"parameterInformation":{}}},"declaration":{},"definition":{},"typeDefinition":{},"implementation":{},"references":{},"documentHighlight":{},"documentSymbol":{"symbolKind":{},"tagSupport":{"valueSet":null}},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}},"resolveSupport":{"properties":null}},"codeLens":{},"documentLink":{},"colorProvider":{},"formatting":{},"rangeFormatting":{},"onTypeFormatting":{},"rename":{},"foldingRange":{},"selectionRange":{},"publishDiagnostics":{"tagSupport":{"valueSet":null}},"callHierarchy":{},"semanticTokens":{"requests":{"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null},"linkedEditingRange":{},"moniker":{},"typeHierarchy":{},"inlineValue":{},"inlayHint":{"resolveSupport":{"properties":null}}},"window":{"workDoneProgress":true,"showMessage":{"messageActionItem":{}},"showDocument":{"support":false}},"general":{"staleRequestSupport":{"cancel":false,"retryOnContentModified":null},"regularExpressions":{"engine":""},"markdown":{"parser":""}}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-3569121049/TestUnknownRevision/bad/nested/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-3569121049/TestUnknownRevision/bad/nested/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-3569121049/TestUnknownRevision/bad/nested/default/work","name":"work"}]}


[Trace - 14:11:09.737 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."],"completionItem":{}},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"documentOnTypeFormattingProvider":{"firstTriggerCharacter":""},"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}},"inlayHintProvider":{}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 027ff3f47d5d6557067324c342c8e14d7da1cf7a\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 14:11:09.737 PM] Sending notification 'initialized'.
...

[Error - Received] 14:11:10.106 PM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-3569121049/TestUnknownRevision/bad/nested/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/nested/default"
--- FAIL: TestUnknownRevision (7.26s)
    --- FAIL: TestUnknownRevision/bad (2.49s)
        --- FAIL: TestUnknownRevision/bad/nested (0.38s)
            --- FAIL: TestUnknownRevision/bad/nested/default (0.38s)
                modfile_test.go:646: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-3569121049/TestUnknownRevision/bad/nested/default/work/a/go.mod]).
2022-09-07 18:17 linux-s390x-ibm tools@3ee17105 go@dfdf5515 x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/default/default"
[Trace - 14:24:56.296 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"executeCommand":{},"semanticTokens":{},"codeLens":{},"inlineValue":{},"inlayHint":{},"configuration":true},"textDocument":{"synchronization":{},"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]},"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null}},"completionItemKind":{},"completionList":{}},"hover":{},"signatureHelp":{"signatureInformation":{"parameterInformation":{}}},"declaration":{},"definition":{},"typeDefinition":{},"implementation":{},"references":{},"documentHighlight":{},"documentSymbol":{"symbolKind":{},"tagSupport":{"valueSet":null}},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}},"resolveSupport":{"properties":null}},"codeLens":{},"documentLink":{},"colorProvider":{},"formatting":{},"rangeFormatting":{},"onTypeFormatting":{},"rename":{},"foldingRange":{},"selectionRange":{},"publishDiagnostics":{"tagSupport":{"valueSet":null}},"callHierarchy":{},"semanticTokens":{"requests":{"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null},"linkedEditingRange":{},"moniker":{},"typeHierarchy":{},"inlineValue":{},"inlayHint":{"resolveSupport":{"properties":null}}},"window":{"workDoneProgress":true,"showMessage":{"messageActionItem":{}},"showDocument":{"support":false}},"general":{"staleRequestSupport":{"cancel":false,"retryOnContentModified":null},"regularExpressions":{"engine":""},"markdown":{"parser":""}}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-3175006681/TestUnknownRevision/bad/default/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-3175006681/TestUnknownRevision/bad/default/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-3175006681/TestUnknownRevision/bad/default/default/work/a","name":"a"}]}


[Trace - 14:24:56.296 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."],"completionItem":{}},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"documentOnTypeFormattingProvider":{"firstTriggerCharacter":""},"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}},"inlayHintProvider":{}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel dfdf55158dcfc3ef1bd436b3b9ed6daa20801fdb\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 14:24:56.296 PM] Sending notification 'initialized'.
...

[Error - Received] 14:24:56.652 PM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-3175006681/TestUnknownRevision/bad/default/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/default/default"
--- FAIL: TestUnknownRevision (10.83s)
    --- FAIL: TestUnknownRevision/bad (3.85s)
        --- FAIL: TestUnknownRevision/bad/default (0.38s)
            --- FAIL: TestUnknownRevision/bad/default/default (0.38s)
                modfile_test.go:646: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-3175006681/TestUnknownRevision/bad/default/default/work/a/go.mod]).
2022-09-16 20:08 linux-s390x-ibm tools@45ad958c go@2d89bec2 x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/default/default"
[Trace - 17:19:53.419 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-2333042351/TestUnknownRevision/bad/default/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-2333042351/TestUnknownRevision/bad/default/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-2333042351/TestUnknownRevision/bad/default/default/work/a","name":"a"}]}


[Trace - 17:19:53.419 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 2d89bec2de0ee9d340346dea6b1506457f5f7722\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 17:19:53.420 PM] Sending notification 'initialized'.
...

[Error - Received] 17:19:53.888 PM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-2333042351/TestUnknownRevision/bad/default/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/default/default"
--- FAIL: TestUnknownRevision (8.61s)
    --- FAIL: TestUnknownRevision/bad (4.73s)
        --- FAIL: TestUnknownRevision/bad/default (0.53s)
            --- FAIL: TestUnknownRevision/bad/default/default (0.53s)
                modfile_test.go:646: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-2333042351/TestUnknownRevision/bad/default/default/work/a/go.mod]).

— watchflakes

@hyangah hyangah modified the milestones: Unreleased, gopls/later Sep 23, 2022
@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && 
        test == "TestUnknownRevision" && `All files must be saved first`
2022-09-22 21:09 linux-s390x-ibm tools@62ae5861 go@42a46206 x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/default/default"
[Trace - 17:16:13.542 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-2818606817/TestUnknownRevision/bad/default/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-2818606817/TestUnknownRevision/bad/default/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-2818606817/TestUnknownRevision/bad/default/default/work/a","name":"a"}]}


[Trace - 17:16:13.543 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 42a46206b97ca7cf4246d3c1230a70cf42ad5bb0\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 17:16:13.556 PM] Sending notification 'initialized'.
...

[Error - Received] 17:16:13.668 PM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-2818606817/TestUnknownRevision/bad/default/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/default/default"
--- FAIL: TestUnknownRevision (7.73s)
    --- FAIL: TestUnknownRevision/bad (2.11s)
        --- FAIL: TestUnknownRevision/bad/default (0.15s)
            --- FAIL: TestUnknownRevision/bad/default/default (0.15s)
                modfile_test.go:646: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-2818606817/TestUnknownRevision/bad/default/default/work/a/go.mod]).

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && 
        test == "TestUnknownRevision" && `All files must be saved first`
2022-09-23 16:53 linux-s390x-ibm tools@eb25de6e go@336ce966 x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/nested/default"
[Trace - 13:38:34.295 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-1735933637/TestUnknownRevision/bad/nested/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-1735933637/TestUnknownRevision/bad/nested/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-1735933637/TestUnknownRevision/bad/nested/default/work","name":"work"}]}


[Trace - 13:38:34.296 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 336ce966e439a269fe5088cc7564181c5b866b61\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 13:38:34.296 PM] Sending notification 'initialized'.
...

[Error - Received] 13:38:34.538 PM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-1735933637/TestUnknownRevision/bad/nested/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/nested/default"
--- FAIL: TestUnknownRevision (8.09s)
    --- FAIL: TestUnknownRevision/bad (2.86s)
        --- FAIL: TestUnknownRevision/bad/nested (0.49s)
            --- FAIL: TestUnknownRevision/bad/nested/default (0.49s)
                modfile_test.go:646: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-1735933637/TestUnknownRevision/bad/nested/default/work/a/go.mod]).

— watchflakes

@findleyr findleyr modified the milestones: gopls/later, gopls/v0.10.0 Sep 28, 2022
@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && 
        test == "TestUnknownRevision" && `All files must be saved first`
2022-09-30 19:58 linux-s390x-ibm tools@3e0355b8 go@aeab76f0 x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/default/default"
[Trace - 19:57:35.250 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-166682984/TestUnknownRevision/bad/default/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-166682984/TestUnknownRevision/bad/default/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-166682984/TestUnknownRevision/bad/default/default/work/a","name":"a"}]}


[Trace - 19:57:35.250 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel aeab76f0befcd6ab1257eae9adb27ac2cb2b7ff8\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 19:57:35.250 PM] Sending notification 'initialized'.
...

[Error - Received] 19:57:35.591 PM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-166682984/TestUnknownRevision/bad/default/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/default/default"
--- FAIL: TestUnknownRevision (9.34s)
    --- FAIL: TestUnknownRevision/bad (2.93s)
        --- FAIL: TestUnknownRevision/bad/default (0.43s)
            --- FAIL: TestUnknownRevision/bad/default/default (0.43s)
                modfile_test.go:646: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-166682984/TestUnknownRevision/bad/default/default/work/a/go.mod]).
2022-10-03 15:32 linux-s390x-ibm tools@55e5cff6 go@6d8ec893 x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/default/default"
[Trace - 16:52:54.145 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-3775673909/TestUnknownRevision/bad/default/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-3775673909/TestUnknownRevision/bad/default/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-3775673909/TestUnknownRevision/bad/default/default/work/a","name":"a"}]}


[Trace - 16:52:54.145 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 6d8ec893039a39f495c8139012e47754e4518b70\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 16:52:54.145 PM] Sending notification 'initialized'.
...

#### End Gopls Test Logs for "TestUnknownRevision/bad/nested/default"
--- FAIL: TestUnknownRevision (10.59s)
    --- FAIL: TestUnknownRevision/bad (1.52s)
        --- FAIL: TestUnknownRevision/bad/default (0.71s)
            --- FAIL: TestUnknownRevision/bad/default/default (0.71s)
                modfile_test.go:646: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-3775673909/TestUnknownRevision/bad/default/default/work/a/go.mod]).
        --- FAIL: TestUnknownRevision/bad/nested (0.81s)
            --- FAIL: TestUnknownRevision/bad/nested/default (0.81s)
                modfile_test.go:646: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-3775673909/TestUnknownRevision/bad/nested/default/work/a/go.mod]).

— watchflakes

@findleyr findleyr modified the milestones: gopls/v0.10.0, gopls/v0.10.1 Oct 11, 2022
@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && 
        test == "TestUnknownRevision" && `All files must be saved first`
2022-10-06 17:35 linux-s390x-ibm tools@15525299 go@9dfadf91 x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/default/default"
[Trace - 13:39:17.418 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-286251658/TestUnknownRevision/bad/default/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-286251658/TestUnknownRevision/bad/default/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-286251658/TestUnknownRevision/bad/default/default/work/a","name":"a"}]}


[Trace - 13:39:17.418 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 9dfadf911d2dcb093c3a37c79869bead0f9f6349\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 13:39:17.418 PM] Sending notification 'initialized'.
...

[Error - Received] 13:39:17.612 PM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-286251658/TestUnknownRevision/bad/default/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/default/default"
--- FAIL: TestUnknownRevision (7.09s)
    --- FAIL: TestUnknownRevision/bad (2.10s)
        --- FAIL: TestUnknownRevision/bad/default (0.25s)
            --- FAIL: TestUnknownRevision/bad/default/default (0.25s)
                modfile_test.go:646: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-286251658/TestUnknownRevision/bad/default/default/work/a/go.mod]).
2022-10-11 21:42 linux-s390x-ibm tools@19a5504f go@4bcf94b0 x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/nested/default"
[Trace - 21:17:35.719 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-39278108/TestUnknownRevision/bad/nested/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-39278108/TestUnknownRevision/bad/nested/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-39278108/TestUnknownRevision/bad/nested/default/work","name":"work"}]}


[Trace - 21:17:35.720 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 4bcf94b0232db65ed5df47e0127cdbc8866aec64\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 21:17:35.720 PM] Sending notification 'initialized'.
...

[Error - Received] 21:17:35.877 PM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-39278108/TestUnknownRevision/bad/nested/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/nested/default"
--- FAIL: TestUnknownRevision (14.87s)
    --- FAIL: TestUnknownRevision/bad (6.19s)
        --- FAIL: TestUnknownRevision/bad/nested (0.17s)
            --- FAIL: TestUnknownRevision/bad/nested/default (0.17s)
                modfile_test.go:646: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-39278108/TestUnknownRevision/bad/nested/default/work/a/go.mod]).
2022-10-11 21:42 linux-s390x-ibm tools@19a5504f go@140bc244 x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/default/default"
[Trace - 17:48:19.506 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-3464625873/TestUnknownRevision/bad/default/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-3464625873/TestUnknownRevision/bad/default/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-3464625873/TestUnknownRevision/bad/default/default/work/a","name":"a"}]}


[Trace - 17:48:19.506 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 140bc24445f3c86b61bfb4d924e1e26f477574a2\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 17:48:19.507 PM] Sending notification 'initialized'.
...

[Error - Received] 17:48:19.574 PM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-3464625873/TestUnknownRevision/bad/default/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/default/default"
--- FAIL: TestUnknownRevision (6.07s)
    --- FAIL: TestUnknownRevision/bad (2.87s)
        --- FAIL: TestUnknownRevision/bad/default (0.15s)
            --- FAIL: TestUnknownRevision/bad/default/default (0.15s)
                modfile_test.go:646: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-3464625873/TestUnknownRevision/bad/default/default/work/a/go.mod]).

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && 
        test == "TestUnknownRevision" && `All files must be saved first`
2022-10-12 18:24 linux-s390x-ibm tools@d3752388 go@6f445a9d x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/default/default"
[Trace - 19:33:46.514 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-1521568178/TestUnknownRevision/bad/default/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-1521568178/TestUnknownRevision/bad/default/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-1521568178/TestUnknownRevision/bad/default/default/work/a","name":"a"}]}


[Trace - 19:33:46.514 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 6f445a9db55f65e55c5be29d3c506ecf3be37915\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 19:33:46.515 PM] Sending notification 'initialized'.
...

[Error - Received] 19:33:47.122 PM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-1521568178/TestUnknownRevision/bad/default/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/default/default"
--- FAIL: TestUnknownRevision (6.64s)
    --- FAIL: TestUnknownRevision/bad (2.29s)
        --- FAIL: TestUnknownRevision/bad/default (0.65s)
            --- FAIL: TestUnknownRevision/bad/default/default (0.65s)
                modfile_test.go:646: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-1521568178/TestUnknownRevision/bad/default/default/work/a/go.mod]).

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && 
        test == "TestUnknownRevision" && `All files must be saved first`
2022-10-19 20:55 linux-s390x-ibm tools@9eda97bc go@6fe3ccd7 x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/default/default"
[Trace - 17:02:22.414 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-1435891169/TestUnknownRevision/bad/default/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-1435891169/TestUnknownRevision/bad/default/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-1435891169/TestUnknownRevision/bad/default/default/work/a","name":"a"}]}


[Trace - 17:02:22.414 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 6fe3ccd74c4bf53552da3d9f59463a8a291f59db\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 17:02:22.414 PM] Sending notification 'initialized'.
...

[Error - Received] 17:02:23.207 PM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-1435891169/TestUnknownRevision/bad/default/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/default/default"
--- FAIL: TestUnknownRevision (14.04s)
    --- FAIL: TestUnknownRevision/bad (5.85s)
        --- FAIL: TestUnknownRevision/bad/default (0.84s)
            --- FAIL: TestUnknownRevision/bad/default/default (0.84s)
                modfile_test.go:646: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-1435891169/TestUnknownRevision/bad/default/default/work/a/go.mod]).

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && 
        test == "TestUnknownRevision" && `All files must be saved first`
2022-10-19 19:08 linux-s390x-ibm tools@b50d7ba6 go@6fe3ccd7 x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/default/default"
[Trace - 16:39:31.268 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-2934067484/TestUnknownRevision/bad/default/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-2934067484/TestUnknownRevision/bad/default/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-2934067484/TestUnknownRevision/bad/default/default/work/a","name":"a"}]}


[Trace - 16:39:31.268 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 6fe3ccd74c4bf53552da3d9f59463a8a291f59db\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 16:39:31.268 PM] Sending notification 'initialized'.
...

[Error - Received] 16:39:31.347 PM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-2934067484/TestUnknownRevision/bad/default/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/default/default"
--- FAIL: TestUnknownRevision (8.32s)
    --- FAIL: TestUnknownRevision/bad (2.04s)
        --- FAIL: TestUnknownRevision/bad/default (0.11s)
            --- FAIL: TestUnknownRevision/bad/default/default (0.11s)
                modfile_test.go:646: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-2934067484/TestUnknownRevision/bad/default/default/work/a/go.mod]).

— watchflakes

@findleyr findleyr modified the milestones: gopls/v0.10.1, gopls/v0.10.2 Nov 1, 2022
@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && 
        test == "TestUnknownRevision" && `All files must be saved first`
2022-10-28 20:13 linux-s390x-ibm tools@e172e97c go@b726b0ca x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/default/default"
[Trace - 21:52:38.469 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":null,"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-1858170290/TestUnknownRevision/bad/default/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-1858170290/TestUnknownRevision/bad/default/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-1858170290/TestUnknownRevision/bad/default/default/work/a","name":"a"}]}


[Trace - 21:52:38.469 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel b726b0cadb5102bb718f879bede0e76d1e5f5c34\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 21:52:38.469 PM] Sending notification 'initialized'.
...

[Error - Received] 21:52:38.728 PM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-1858170290/TestUnknownRevision/bad/default/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/default/default"
--- FAIL: TestUnknownRevision (6.78s)
    --- FAIL: TestUnknownRevision/bad (2.81s)
        --- FAIL: TestUnknownRevision/bad/default (0.27s)
            --- FAIL: TestUnknownRevision/bad/default/default (0.27s)
                modfile_test.go:646: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-1858170290/TestUnknownRevision/bad/default/default/work/a/go.mod]).

— watchflakes

@gopherbot
Copy link

Change https://go.dev/cl/448115 mentions this issue: gopls/internal/regtest: simplify awaiting diagnostics from a change

@gopherbot gopherbot reopened this Nov 21, 2022
@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && 
        test == "TestUnknownRevision" && `All files must be saved first`
2022-11-08 17:28 linux-s390x-ibm tools@9474ca31 go@0409314d x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/nested/default"
[Trace - 12:35:01.400 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-2112600167/TestUnknownRevision/bad/nested/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-2112600167/TestUnknownRevision/bad/nested/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-2112600167/TestUnknownRevision/bad/nested/default/work","name":"work"}]}


[Trace - 12:35:01.401 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 0409314db39db8f1d587fff31f79a24f1aa36ad2\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 12:35:01.401 PM] Sending notification 'initialized'.
...

[Error - Received] 12:35:01.759 PM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-2112600167/TestUnknownRevision/bad/nested/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/nested/default"
--- FAIL: TestUnknownRevision (6.36s)
    --- FAIL: TestUnknownRevision/bad (2.09s)
        --- FAIL: TestUnknownRevision/bad/nested (0.55s)
            --- FAIL: TestUnknownRevision/bad/nested/default (0.55s)
                modfile_test.go:646: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-2112600167/TestUnknownRevision/bad/nested/default/work/a/go.mod]).

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && 
        test == "TestUnknownRevision" && `All files must be saved first`
2022-11-22 19:46 linux-s390x-ibm tools@5c356176 go@861ba027 x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/nested/default"
[Trace - 15:03:57.217 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-2711515139/TestUnknownRevision/bad/nested/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-2711515139/TestUnknownRevision/bad/nested/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-2711515139/TestUnknownRevision/bad/nested/default/work","name":"work"}]}


[Trace - 15:03:57.240 PM] Received response 'initialize - (1)' in 22ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.19.3\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 15:03:57.240 PM] Sending notification 'initialized'.
...

[Error - Received] 15:03:57.597 PM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-2711515139/TestUnknownRevision/bad/nested/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/nested/default"
--- FAIL: TestUnknownRevision (7.43s)
    --- FAIL: TestUnknownRevision/bad (2.92s)
        --- FAIL: TestUnknownRevision/bad/nested (0.55s)
            --- FAIL: TestUnknownRevision/bad/nested/default (0.55s)
                modfile_test.go:644: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-2711515139/TestUnknownRevision/bad/nested/default/work/a/go.mod]).
2022-11-23 14:17 linux-s390x-ibm tools@d39685aa go@861ba027 x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/nested/default"
[Trace - 09:20:57.328 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-3685805765/TestUnknownRevision/bad/nested/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-3685805765/TestUnknownRevision/bad/nested/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-3685805765/TestUnknownRevision/bad/nested/default/work","name":"work"}]}


[Trace - 09:20:57.328 AM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.19.3\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 09:20:57.328 AM] Sending notification 'initialized'.
...

[Error - Received] 09:20:57.485 AM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-3685805765/TestUnknownRevision/bad/nested/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/nested/default"
--- FAIL: TestUnknownRevision (5.91s)
    --- FAIL: TestUnknownRevision/bad (2.10s)
        --- FAIL: TestUnknownRevision/bad/nested (0.17s)
            --- FAIL: TestUnknownRevision/bad/nested/default (0.17s)
                modfile_test.go:644: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-3685805765/TestUnknownRevision/bad/nested/default/work/a/go.mod]).

— watchflakes

@findleyr findleyr modified the milestones: gopls/v0.11.0, gopls/v0.12.0 Dec 8, 2022
@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && 
        test == "TestUnknownRevision" && `All files must be saved first`
2022-12-13 19:48 linux-s390x-ibm tools@9ec85531 go@f92317e6 x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/default/default"
[Trace - 16:39:40.765 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-703050515/TestUnknownRevision/bad/default/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-703050515/TestUnknownRevision/bad/default/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-703050515/TestUnknownRevision/bad/default/default/work/a","name":"a"}]}


[Trace - 16:39:40.765 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.18.9\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 16:39:40.765 PM] Sending notification 'initialized'.
...

[Error - Received] 16:39:41.108 PM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-703050515/TestUnknownRevision/bad/default/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/default/default"
--- FAIL: TestUnknownRevision (4.87s)
    --- FAIL: TestUnknownRevision/bad (2.18s)
        --- FAIL: TestUnknownRevision/bad/default (0.38s)
            --- FAIL: TestUnknownRevision/bad/default/default (0.38s)
                modfile_test.go:644: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-703050515/TestUnknownRevision/bad/default/default/work/a/go.mod]).

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && 
        test == "TestUnknownRevision" && `All files must be saved first`
2022-12-17 19:19 linux-s390x-ibm tools@eb70795a go@45ba8ba9 x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/nested/default"
[Trace - 14:33:32.713 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-421351595/TestUnknownRevision/bad/nested/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-421351595/TestUnknownRevision/bad/nested/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-421351595/TestUnknownRevision/bad/nested/default/work","name":"work"}]}


[Trace - 14:33:32.714 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.19.4\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 14:33:32.714 PM] Sending notification 'initialized'.
...

[Error - Received] 14:33:33.079 PM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-421351595/TestUnknownRevision/bad/nested/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/nested/default"
--- FAIL: TestUnknownRevision (10.48s)
    --- FAIL: TestUnknownRevision/bad (3.36s)
        --- FAIL: TestUnknownRevision/bad/nested (0.39s)
            --- FAIL: TestUnknownRevision/bad/nested/default (0.39s)
                modfile_test.go:627: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-421351595/TestUnknownRevision/bad/nested/default/work/a/go.mod]).

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && 
        test == "TestUnknownRevision" && `All files must be saved first`
2022-11-17 20:46 linux-s390x-ibm tools@dea100b1 go@205f636e x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/default/default"
[Trace - 03:28:13.739 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-2121383390/TestUnknownRevision/bad/default/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-2121383390/TestUnknownRevision/bad/default/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-2121383390/TestUnknownRevision/bad/default/default/work/a","name":"a"}]}


[Trace - 03:28:13.740 AM] Received response 'initialize - (1)' in 1ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_tests","gopls.run_vulncheck_exp","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 205f636e0ab491b7a06e7b7879abb897cdaaf1b4\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 03:28:13.740 AM] Sending notification 'initialized'.
...

[Error - Received] 03:28:13.820 AM #5 All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-2121383390/TestUnknownRevision/bad/default/default/work/a/go.mod]).


#### End Gopls Test Logs for "TestUnknownRevision/bad/default/default"
--- FAIL: TestUnknownRevision (8.09s)
    --- FAIL: TestUnknownRevision/bad (2.31s)
        --- FAIL: TestUnknownRevision/bad/default (0.26s)
            --- FAIL: TestUnknownRevision/bad/default/default (0.26s)
                modfile_test.go:644: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-2121383390/TestUnknownRevision/bad/default/default/work/a/go.mod]).

— watchflakes

@gopherbot
Copy link

Change https://go.dev/cl/461418 mentions this issue: gopls/internal/lsp/cache: don't cache if mtime is too recent

@findleyr
Copy link
Contributor

Confusingly, there was a second bug (root caused in https://go.dev/cl/461418) which I believe was causing the same symptom, albeit with less frequency and only on s390x, which must have low clock precision.

I'm pretty confident in the fix.

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && 
        test == "TestUnknownRevision" && `All files must be saved first`
2023-01-11 18:41 linux-s390x-ibm tools@b7989342 go@1e9ff255 x/tools/gopls/internal/regtest/modfile.TestUnknownRevision (log) 
#### Start Gopls Test Logs for "TestUnknownRevision/bad/nested/default"
[Trace - 13:47:50.754 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-3888226122/TestUnknownRevision/bad/nested/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-3888226122/TestUnknownRevision/bad/nested/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-3888226122/TestUnknownRevision/bad/nested/default/work","name":"work"}]}


[Trace - 13:47:50.754 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.19.5\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 13:47:50.754 PM] Sending notification 'initialized'.
...
[Trace - 13:47:50.891 PM] Received notification 'window/logMessage'.
Params: {"type":1,"message":"2023/01/11 13:47:50 workspace packages: diagnosing file:///data/golang/workdir/tmp/gopls-regtest-3888226122/TestUnknownRevision/bad/nested/default/work/a/go.mod: packages.Load error: err: exit status 1: stderr: go: example.com@v1.2.3: missing go.sum entry; to add it:\n\tgo mod download example.com\ngo: example.com@v1.2.3: missing go.sum entry; to add it:\n\tgo mod download example.com\n\n"}


#### End Gopls Test Logs for "TestUnknownRevision/bad/nested/default"
--- FAIL: TestUnknownRevision (4.56s)
    --- FAIL: TestUnknownRevision/bad (1.61s)
        --- FAIL: TestUnknownRevision/bad/nested (0.15s)
            --- FAIL: TestUnknownRevision/bad/nested/default (0.15s)
                modfile_test.go:627: All files must be saved first (unsaved: [/data/golang/workdir/tmp/gopls-regtest-3888226122/TestUnknownRevision/bad/nested/default/work/a/go.mod]).

— watchflakes

@golang golang locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@findleyr findleyr

Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
gopls/v0.12.0
Development

No branches or pull requests
4 participants
@hyangah @bcmills @gopherbot @findleyr