Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/updatestd: test failures without useful output #55067

Closed
bcmills opened this issue Sep 14, 2022 · 3 comments
Closed

x/build/cmd/updatestd: test failures without useful output #55067

bcmills opened this issue Sep 14, 2022 · 3 comments
Assignees
@dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
Go Release Team
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 14, 2022 

2022/09/08 04:11:11 > go list -mod=readonly -m -json all
2022/09/08 04:11:11 command failed: exit status 1
FAIL	golang.org/x/build/cmd/updatestd	92.408s

It looks like the go list command failed, but I can't dig into it further because the stderr stream from the go list command is not logged. A good first step would probably be to update this test in line with https://go.dev/wiki/CodeReviewComments#useful-test-failures.
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Sep 14, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 14, 2022
@bcmills
Copy link
Contributor Author

bcmills commented Sep 14, 2022

greplogs -l -e 'command failed(?:.*\n)*FAIL\s+golang.org/x/build/cmd/updatestd'
2022-09-08T10:48:29-b4daf1e-2960431/darwin-amd64-11_0
2021-01-20T09:06:08-789b929-928bda4/darwin-amd64-10_15

@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 14, 2022
@bcmills bcmills mentioned this issue Sep 14, 2022
Closed
@dmitshur dmitshur self-assigned this Sep 16, 2022
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 16, 2022
@gopherbot
Copy link

Change https://go.dev/cl/431357 mentions this issue: cmd/updatestd: print stderr in runOut when command fails

gopherbot pushed a commit to golang/build that referenced this issue Sep 16, 2022
@dmitshur @gopherbot
cmd/updatestd: print stderr in runOut when command fails
03f4f13 
Stderr is much more likely to contain useful information than
stdout in the unexpected case of the command failing. Show it.

For golang/go#55067.

Change-Id: Ice85e957bb7d9104da475d7616519bbfbae105e3
Reviewed-on: https://go-review.googlesource.com/c/build/+/431357
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@dmitshur dmitshur added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Sep 16, 2022
@dmitshur dmitshur added this to Planned in Go Release Team Sep 27, 2022
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@golang golang locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
Go Release
Archived in project
Go Release Team
Planned
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot