go/types: named types defined within a function print as if defined at package scope #5501
Labels
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Comments
Here's a concrete suggestion: the local type should have name that is not a valid Go
identifier, e.g. main.T$1, where 1 is a sequence number for fresh identifiers.
For the record: gc and go/types behave the same:
% cat ~/5501.go
package main
import "fmt"
type T int
var outer T
func main() {
type T int
var inner T
fmt.Printf("%T %T\n", outer, inner)
}
% go run ~/5501.go
main.T main.T
% ./ssadump -run ~/5501.go
main.T main.T
|
rsc
changed the title
griesemer
changed the title
|
This shouldn't be too hard to address. Try for 1.9. |
|
Better suggestion than #5501 (comment): Print a type together with position information; that will remove any ambiguity. This can be optimized such that the position information is only present if there two types with the same name in the same package. Shouldn't be too hard to do but may affect tests that rely on a specific output format. Thus moving to Go1.10. |
seankhliao
added
the
NeedsInvestigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
package main type T int func f() { type T int } Both of these types are printed as "main.T". This is ambiguous and confusing; the f-local type should have a different name. Not sure what 6g does.The text was updated successfully, but these errors were encountered: