Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: revisit the inconsistent vendoring error diagnostics message #54987

Open
hyangah opened this issue Sep 9, 2022 · 0 comments
Open
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.

Comments

@hyangah
Copy link
Contributor

hyangah commented Sep 9, 2022

Screen Shot 2022-09-09 at 7 04 56 PM

I was originally about to propose to move the issue URL to LSP Diagnostics CodeDescription href field (due to the limitation in vscode UI, links in diagnostics message can be easily clicked or copied otherwise). However, reading the issue details, I am not sure how helpful the linked issue is to general audience. Improvement I think of

  • Explain what is happening - e.g. "this error prohibits the language server from function correctly. Please fix this issue by running "go mod vendor".
  • Have a better information page that explains what is inconsistent vendoring means, and what's the impact on the editor's functionality (and from there, link the issue 39164 if we want) and supply the link using CodeDescription href field.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 9, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 9, 2022
@dle8 dle8 modified the milestones: Unreleased, gopls/unplanned Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants