Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: handle inconsistent vendoring error better #54986

Open
hyangah opened this issue Sep 9, 2022 · 2 comments
Open

x/tools/gopls: handle inconsistent vendoring error better #54986

hyangah opened this issue Sep 9, 2022 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/unplanned

Comments

@hyangah
Copy link
Contributor

hyangah commented Sep 9, 2022 •
edited
Loading

gopls version: v0.9.5
go version:1.19
gopls settings: "gopls": { "ui.semanticTokens": true }

When inconsistent vendoring is detected, gopls fails to load workspace and shows an overwhelming notification:

Screen Shot 2022-09-09 at 6 42 30 PM

(the above screenshot was taken after starting gopls)

  1. Translate this go command error to a friendly actionable error message. It's already done in diagnostics.

Screen Shot 2022-09-09 at 7 04 56 PM

  1. Help users to pay attention to the go.mod diagnostic that already offers a quick-fix.

  2. (feeling adventurous :-P) Investigate if we can get rid of this error - what if gopls falls back to load workspace as if there was no vendor directory while reporting the inconsistent vendoring issue in go.mod? If the fix for cmd/go: return best-effort results despite inconsistent vendoring #39164 helps, should we prioritize it?
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 9, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 9, 2022
@dle8 dle8 added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 16, 2022
@dle8 dle8 modified the milestones: Unreleased, gopls/unplanned Sep 16, 2022
@chinglinwen
Copy link

chinglinwen commented Oct 21, 2022 •
edited
Loading

encounter the same issue here, for example this repo: https://github.com/opencontainers/runc, branch: main or v1.1.4 ( for future check )

image

[wenzhenglin@wendev01v runc]$ gopls version
golang.org/x/tools/gopls v0.9.5
    golang.org/x/tools/gopls@v0.9.5 h1:F3TO5th6TUg40FHrpxZfMkMlVaaTmByeEvylgVHGH2A=
[wenzhenglin@wendev01v runc]$ go version
go version go1.18.2 linux/amd64

gopls setting

 "gopls": {
        // Add parameter placeholders when completing a function.
        "usePlaceholders": true,
        // If true, enable additional analyses with staticcheck.
        // Warning: This will significantly increase memory usage.
        "staticcheck": false,
        "buildFlags": [
            "-tags=wireinject"
        ],
        "experimentalWorkspaceModule": true,
        "build.directoryFilters": [
            "-vendor"
        ]
    },

@chinglinwen
Copy link

chinglinwen commented Oct 24, 2022 •
edited
Loading

encounter the same issue here, for example this repo: https://github.com/opencontainers/runc, branch: main or v1.1.4 ( for future check )

image

[wenzhenglin@wendev01v runc]$ gopls version
golang.org/x/tools/gopls v0.9.5
    golang.org/x/tools/gopls@v0.9.5 h1:F3TO5th6TUg40FHrpxZfMkMlVaaTmByeEvylgVHGH2A=
[wenzhenglin@wendev01v runc]$ go version
go version go1.18.2 linux/amd64

gopls setting

 "gopls": {
        // Add parameter placeholders when completing a function.
        "usePlaceholders": true,
        // If true, enable additional analyses with staticcheck.
        // Warning: This will significantly increase memory usage.
        "staticcheck": false,
        "buildFlags": [
            "-tags=wireinject"
        ],
        "experimentalWorkspaceModule": true,
        "build.directoryFilters": [
            "-vendor"
        ]
    },

After I disable experimentalWorkspaceModule setting, the above issue gone. I reply here, in case if someone encounter the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/unplanned
Development

No branches or pull requests
4 participants
@hyangah @gopherbot @chinglinwen @dle8