Skip to content

x/exp/slog: tests consistently failing on many builders #54978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcmills opened this issue Sep 9, 2022 · 3 comments
Closed

x/exp/slog: tests consistently failing on many builders #54978

bcmills opened this issue Sep 9, 2022 · 3 comments
Assignees
@jba
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Milestone
Go1.20

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 9, 2022

greplogs -l -e FAIL\\s+golang\\.org/x/exp/slog --since=2022-08-01 --details

2022-09-09T13:00:31-4397029-218294f/darwin-amd64-10_14
2022-09-09T13:00:31-4397029-218294f/darwin-amd64-10_15
2022-09-09T13:00:31-4397029-218294f/linux-amd64
2022-09-09T13:00:31-4397029-218294f/linux-amd64-longtest
2022-09-09T13:00:31-4397029-218294f/linux-amd64-nocgo
2022-09-09T13:00:31-4397029-218294f/linux-amd64-race
2022-09-09T13:00:31-4397029-218294f/windows-386-2008
2022-09-09T13:00:31-4397029-218294f/windows-386-2008-newcc
2022-09-09T13:00:31-4397029-218294f/windows-amd64-2016
2022-09-09T13:00:31-4397029-218294f/windows-amd64-2016-newcc
2022-09-09T13:00:31-4397029-218294f/windows-amd64-longtest
2022-09-09T13:00:31-4397029-218294f/windows-amd64-longtest-newcc
2022-09-09T13:00:09-91042ec-4108970/darwin-amd64-10_14
2022-09-09T13:00:09-91042ec-4108970/darwin-amd64-10_15
2022-09-09T13:00:09-91042ec-4108970/linux-amd64
2022-09-09T13:00:09-91042ec-4108970/linux-amd64-longtest
2022-09-09T13:00:09-91042ec-4108970/linux-amd64-nocgo
2022-09-09T13:00:09-91042ec-4108970/linux-amd64-race
2022-09-09T13:00:09-91042ec-4108970/windows-386-2008
2022-09-09T13:00:09-91042ec-4108970/windows-386-2008-newcc
2022-09-09T13:00:09-91042ec-4108970/windows-amd64-2016
2022-09-09T13:00:09-91042ec-4108970/windows-amd64-2016-newcc
2022-09-09T13:00:09-91042ec-4108970/windows-amd64-longtest
2022-09-09T13:00:09-91042ec-4108970/windows-amd64-longtest-newcc
2022-09-09T12:46:45-60527bc-4108970/darwin-amd64-10_14
2022-09-09T12:46:45-60527bc-4108970/darwin-amd64-10_15
2022-09-09T12:46:45-60527bc-4108970/windows-386-2008
2022-09-09T12:46:45-60527bc-4108970/windows-386-2008-newcc
2022-09-09T12:46:45-60527bc-4108970/windows-amd64-2016
2022-09-09T12:46:45-60527bc-4108970/windows-amd64-2016-newcc
2022-09-09T12:46:45-60527bc-4108970/windows-amd64-longtest
2022-09-09T12:46:45-60527bc-4108970/windows-amd64-longtest-newcc
2022-09-09T12:41:27-bee5968-4108970/linux-amd64-race
2022-09-09T01:04:57-145caa8-76c94eb/linux-amd64-race
2022-09-06T22:23:43-fcb1a31-c83e1b6/linux-amd64-race

(35 matching logs)

(attn @jba; CC @mknyszek)
@gopherbot gopherbot added this to the Unreleased milestone Sep 9, 2022
@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Sep 9, 2022
@bcmills bcmills modified the milestones: Unreleased, Go1.20 Sep 9, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/430075 mentions this issue: slog: fix race failures

@bcmills bcmills mentioned this issue Sep 14, 2022
Closed
@bcmills
Copy link
Contributor Author

bcmills commented Sep 14, 2022

Reopening for one last failure mode on linux-amd64-race:

--- FAIL: TestAlloc (0.00s)
    buffer_test.go:29: got 1 allocs, want 0
FAIL
FAIL	golang.org/x/exp/slog/internal/buffer	0.027s

@bcmills bcmills reopened this Sep 14, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/431056 mentions this issue: slog/internal/buffer: don't run alloc test with race detector

@bcmills bcmills mentioned this issue Sep 20, 2022
Closed
@golang golang locked and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jba jba

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Projects
None yet
Milestone
Go1.20
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @jba