Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: Reallow duplicate attributes in CSRs. #54936

Closed
robstradling opened this issue Sep 7, 2022 · 4 comments
Closed

crypto/x509: Reallow duplicate attributes in CSRs. #54936

robstradling opened this issue Sep 7, 2022 · 4 comments
Assignees
@rolandshoemaker
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.20

Comments

@robstradling
Copy link
Contributor

Tracking https://go-review.googlesource.com/c/go/+/428636

If accepted, I'd like this to be considered for backport to the next 1.19 minor release.
@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 7, 2022
@mknyszek mknyszek added this to the Backlog milestone Sep 7, 2022
@mknyszek
Copy link
Contributor

mknyszek commented Sep 7, 2022

CC @golang/security

@rolandshoemaker rolandshoemaker self-assigned this Oct 3, 2022
@rolandshoemaker
Copy link
Member

Fixed by http://go.dev/cl/428636.

@robstradling robstradling mentioned this issue Jan 3, 2023
Closed
@FiloSottile
Copy link
Contributor

This was a fix for a regression introduced by #50988, and #57556 is the Go 1.19 backport request.

@gopherbot
Copy link

Change https://go.dev/cl/460236 mentions this issue: [release-branch.go1.19] crypto/x509: reallow duplicate attributes in CSRs

gopherbot pushed a commit that referenced this issue Jan 4, 2023
@robstradling @gopherbot
[release-branch.go1.19] crypto/x509: reallow duplicate attributes in …
e04be8b 
…CSRs

Fixes #57556
Updates #54936

Change-Id: I3fb4331c2b1b6adafbac3e76eaf66c79cd5ef56f
Reviewed-on: https://go-review.googlesource.com/c/go/+/428636
Run-TryBot: Roland Shoemaker <roland@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Auto-Submit: Roland Shoemaker <roland@golang.org>
(cherry picked from commit 56d1820)
Reviewed-on: https://go-review.googlesource.com/c/go/+/460236
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Auto-Submit: Heschi Kreinick <heschi@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 5, 2023
@dmitshur dmitshur modified the milestones: Backlog, Go1.19, Go1.20 Jan 5, 2023
@golang golang locked and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rolandshoemaker rolandshoemaker

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.20
Development

No branches or pull requests
6 participants
@robstradling @FiloSottile @mknyszek @dmitshur @rolandshoemaker @gopherbot