Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: ProxyFromEnvironment documentation is wrong #54890

Closed
dfawley opened this issue Sep 6, 2022 · 3 comments
Closed

net/http: ProxyFromEnvironment documentation is wrong #54890

dfawley opened this issue Sep 6, 2022 · 3 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@dfawley
Copy link

dfawley commented Sep 6, 2022

After the change in #40909 (referenced via #45227), the documentation for ProxyFromEnvironment still incorrectly claims:

HTTPS_PROXY takes precedence over HTTP_PROXY for https requests.

It seems HTTP_PROXY is no longer used at all for https requests. The documentation here should have been fixed when the breaking change was made in Go 1.16.
@dfawley dfawley mentioned this issue Sep 6, 2022
Closed
@mknyszek mknyszek added this to the Backlog milestone Sep 6, 2022
@mknyszek
Copy link
Contributor

mknyszek commented Sep 6, 2022

CC @neild

@mknyszek mknyszek added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 6, 2022
@gopherbot
Copy link

Change https://go.dev/cl/428775 mentions this issue: net/http: clarify proxy selection from environment

@gopherbot
Copy link

Change https://go.dev/cl/428795 mentions this issue: http/httpproxy: remove comment on https proxy precedance

gopherbot pushed a commit to golang/net that referenced this issue Sep 7, 2022
@seankhliao @gopherbot
http/httpproxy: remove comment on https proxy precedance
1e95f45 
For golang/go#40909
For golang/go#54890

Change-Id: I1de1803f8fd00f54290404a8760d9f704ff766c3
Reviewed-on: https://go-review.googlesource.com/c/net/+/428795
Auto-Submit: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
WeiminShang added a commit to WeiminShang/net that referenced this issue Nov 16, 2022
@WeiminShang @gopherbot
http/httpproxy: remove comment on https proxy precedance
e4d29b1 
For golang/go#40909
For golang/go#54890

Change-Id: I1de1803f8fd00f54290404a8760d9f704ff766c3
Reviewed-on: https://go-review.googlesource.com/c/net/+/428795
Auto-Submit: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
@golang golang locked and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@mknyszek @gopherbot @dfawley