encoding/json: TestBlocking test fails #5486
Labels
Comments
A quick update. It looks like there is some confusion about scanning the incoming arguments of a goroutine. If I change the following line from testBlocking go w.Write([]byte(enc)) to force writing the argument to Write onto the stack b := []byte(enc) _ = b go w.Write(b) the crash will no longer reproduce. |
This crash is caused by the GC ignoring the incoming arguments of a function with unknown argument size when that function happens to be the initial function of a not started goroutine. There is special case code in the general stack scanner to handle functions with an unknown argument size. This logic needs to be replicated in the not started goroutine stack scanner. I will have a patch shortly. Fortunately, it is a one-liner. Status changed to Started. |
|
Owner changed to @lexprfuncall. |
|
This issue was closed by revision 50ba6e1. Status changed to Fixed. |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
# hg id 909d1af80cd0+ # hg diff diff -r 909d1af80cd0 src/pkg/encoding/json/stream_test.go --- a/src/pkg/encoding/json/stream_test.go Tue May 14 16:38:12 2013 -0700 +++ b/src/pkg/encoding/json/stream_test.go Thu May 16 10:17:30 2013 +1000 @@ -177,6 +177,12 @@ } func TestBlocking(t *testing.T) { + for i := 0; i < 1000; i++ { + testBlocking(t) + } +} + +func testBlocking(t *testing.T) { for _, enc := range blockingTests { r, w := net.Pipe() go w.Write([]byte(enc)) # go test -v -run=Blo === RUN TestBlocking --- FAIL: TestBlocking (0.02 seconds) stream_test.go:194: decoding [1, 2, 3]: invalid character '\x00' looking for beginning of value FAIL exit status 1 FAIL encoding/json 0.027s # I use linux/386. It looks like broken by: changeset: 16794:909d1af80cd0 user: Carl Shapiro <cshapiro@google.com> date: Tue May 14 16:38:12 2013 -0700 summary: runtime: enable stack scanning by frames AlexThe text was updated successfully, but these errors were encountered: