Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/lsp: re-enable/fix disabled tests (tracking issue) #54822

Closed
griesemer opened this issue Sep 1, 2022 · 8 comments
Closed

x/tools/internal/lsp: re-enable/fix disabled tests (tracking issue) #54822

griesemer opened this issue Sep 1, 2022 · 8 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.15.0

Comments

@griesemer
Copy link
Contributor

Because of changes to the go/parser and go/types, some lsp tests were disabled. This issue tracks the respective CL so we can re-enable and/or fix the tests.

Tentatively set for Go 1.20 but may be moved if necessary.
@griesemer griesemer added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 1, 2022
@griesemer griesemer added this to the Go1.20 milestone Sep 1, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 1, 2022
@gopherbot
Copy link

Change https://go.dev/cl/427654 mentions this issue: x/tools/internal/lsp/source: disable some tests for std lib changes

gopherbot pushed a commit to golang/tools that referenced this issue Sep 1, 2022
@griesemer
x/tools/internal/lsp/source: disable some tests for std lib changes
40cfaff 
CL 425716 changes parser behavior for incorrect code (it is more
lenient) which breaks a few lsp tests. Disable them for now so we
can submit CL 425716.

For golang/go#54511.
For golang/go#54822.

Change-Id: I00fa67e29628137f3e4e44c38e92094ea581a61b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/427654
Reviewed-by: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Griesemer <gri@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/428054 mentions this issue: x/tools/internal/lsp/source: disable some tests for std lib changes

gopherbot pushed a commit to golang/tools that referenced this issue Sep 2, 2022
@griesemer @gopherbot
x/tools/internal/lsp/source: disable some tests for std lib changes
5ba8541 
CL 410955 changes printing of unions which breaks a few lsp tests.
Disable them for now so we can submit CL 410955.

For golang/go#53279.
For golang/go#54822.

Change-Id: I54ff99a4f5530181a39557b6b62e776af082c28d
Reviewed-on: https://go-review.googlesource.com/c/tools/+/428054
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Griesemer <gri@google.com>
@gopherbot
Copy link

gopherbot commented Sep 2, 2022 •
edited by griesemer

Change https://go.dev/cl/428055 mentions this issue: x/tools/internal/typeparams: disable some tests for std lib changes

Note: This CL is now using reg. expressions and so the tests are working as expected. Nothing to do here.

gopherbot pushed a commit to golang/tools that referenced this issue Sep 2, 2022
@griesemer @gopherbot
x/tools/internal/typeparams: use regexp to match wanted result
6a585a2 
CL 410955 changes printing of unions which breaks two typeparams tests.
Use regexp matching and adjust the wanted results accordingly.

For golang/go#53279.
For golang/go#54822.

Change-Id: I7060df47d36ce3069570237dafff024aaad637a5
Reviewed-on: https://go-review.googlesource.com/c/tools/+/428055
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/429295 mentions this issue: x/tools/go/ssa: disable slice-to-array test

gopherbot pushed a commit to golang/tools that referenced this issue Sep 7, 2022
@griesemer @gopherbot
x/tools/go/ssa: disable slice-to-array test
308e02c 
CL 428938 implements slice to array conversions in the type checkers,
per accepted proposal issue golang/go#46505. The disabled test was
expected to fail, but it won't fail anymore for Go 1.20 and higher.
Disable it for now (and track it in golang/go#54822) so we can make
progress with CL 428938.

For golang/go#46505.
For golang/go#54822.

Change-Id: I87fc78dccaa2bf1517cf875fec97855e360d0f25
Reviewed-on: https://go-review.googlesource.com/c/tools/+/429295
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Tim King <taking@google.com>
@griesemer
Copy link
Contributor Author

@findleyr Is there anything left to do here for 1.20? Should this be moved over to 1.21, or can it be closed?

@findleyr
Copy link
Contributor

Yes there is, though it needn't be associated with the 1.20 milestone.

I'd prefer to leave it in the milestone for this week, in case there are any fixes required to re-enable the test. I plan to get to it this week.

@findleyr findleyr modified the milestones: Go1.20, gopls/v0.11.0 Nov 18, 2022
@findleyr
Copy link
Contributor

Moved this to a gopls milestone, as it need not be in a Go milestone: we will endeavor to re-enable these tests before gopls@v0.11.0, which is the version of gopls corresponding to Go 1.20.

@findleyr findleyr modified the milestones: gopls/v0.12.0, gopls/v0.13.0 Mar 27, 2023
CarlosRosuero pushed a commit to CarlosRosuero/typeparams that referenced this issue Jun 13, 2023
@griesemer @gopherbot
x/tools/internal/typeparams: use regexp to match wanted result
736510f 
CL 410955 changes printing of unions which breaks two typeparams tests.
Use regexp matching and adjust the wanted results accordingly.

For golang/go#53279.
For golang/go#54822.

Change-Id: I7060df47d36ce3069570237dafff024aaad637a5
Reviewed-on: https://go-review.googlesource.com/c/tools/+/428055
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
@adonovan adonovan added the Testing An issue that has been verified to require only test changes, not just a test failure. label Aug 31, 2023
@findleyr findleyr modified the milestones: gopls/v0.14.0, gopls/v0.14.1 Oct 9, 2023
@findleyr findleyr modified the milestones: gopls/v0.14.2, gopls/v0.15.0 Nov 14, 2023
@gopherbot
Copy link

Change https://go.dev/cl/557397 mentions this issue: gopls/internal/test/marker: re-enable some tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.15.0
Development

No branches or pull requests
4 participants
@adonovan @griesemer @gopherbot @findleyr