-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/internal/lsp: re-enable/fix disabled tests (tracking issue) #54822
Comments
Change https://go.dev/cl/427654 mentions this issue: |
CL 425716 changes parser behavior for incorrect code (it is more lenient) which breaks a few lsp tests. Disable them for now so we can submit CL 425716. For golang/go#54511. For golang/go#54822. Change-Id: I00fa67e29628137f3e4e44c38e92094ea581a61b Reviewed-on: https://go-review.googlesource.com/c/tools/+/427654 Reviewed-by: Robert Griesemer <gri@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Robert Griesemer <gri@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
Change https://go.dev/cl/428054 mentions this issue: |
CL 410955 changes printing of unions which breaks a few lsp tests. Disable them for now so we can submit CL 410955. For golang/go#53279. For golang/go#54822. Change-Id: I54ff99a4f5530181a39557b6b62e776af082c28d Reviewed-on: https://go-review.googlesource.com/c/tools/+/428054 Auto-Submit: Robert Griesemer <gri@google.com> Reviewed-by: Robert Griesemer <gri@google.com> Reviewed-by: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Robert Griesemer <gri@google.com>
Change https://go.dev/cl/428055 mentions this issue: Note: This CL is now using reg. expressions and so the tests are working as expected. Nothing to do here. |
CL 410955 changes printing of unions which breaks two typeparams tests. Use regexp matching and adjust the wanted results accordingly. For golang/go#53279. For golang/go#54822. Change-Id: I7060df47d36ce3069570237dafff024aaad637a5 Reviewed-on: https://go-review.googlesource.com/c/tools/+/428055 Auto-Submit: Robert Griesemer <gri@google.com> Reviewed-by: Robert Griesemer <gri@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Robert Griesemer <gri@google.com>
Change https://go.dev/cl/429295 mentions this issue: |
CL 428938 implements slice to array conversions in the type checkers, per accepted proposal issue golang/go#46505. The disabled test was expected to fail, but it won't fail anymore for Go 1.20 and higher. Disable it for now (and track it in golang/go#54822) so we can make progress with CL 428938. For golang/go#46505. For golang/go#54822. Change-Id: I87fc78dccaa2bf1517cf875fec97855e360d0f25 Reviewed-on: https://go-review.googlesource.com/c/tools/+/429295 Auto-Submit: Robert Griesemer <gri@google.com> Reviewed-by: Robert Griesemer <gri@google.com> Run-TryBot: Robert Griesemer <gri@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Tim King <taking@google.com>
@findleyr Is there anything left to do here for 1.20? Should this be moved over to 1.21, or can it be closed? |
Yes there is, though it needn't be associated with the 1.20 milestone. I'd prefer to leave it in the milestone for this week, in case there are any fixes required to re-enable the test. I plan to get to it this week. |
Moved this to a gopls milestone, as it need not be in a Go milestone: we will endeavor to re-enable these tests before gopls@v0.11.0, which is the version of gopls corresponding to Go 1.20. |
CL 410955 changes printing of unions which breaks two typeparams tests. Use regexp matching and adjust the wanted results accordingly. For golang/go#53279. For golang/go#54822. Change-Id: I7060df47d36ce3069570237dafff024aaad637a5 Reviewed-on: https://go-review.googlesource.com/c/tools/+/428055 Auto-Submit: Robert Griesemer <gri@google.com> Reviewed-by: Robert Griesemer <gri@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Robert Griesemer <gri@google.com>
Change https://go.dev/cl/557397 mentions this issue: |
Because of changes to the go/parser and go/types, some lsp tests were disabled. This issue tracks the respective CL so we can re-enable and/or fix the tests.
Tentatively set for Go 1.20 but may be moved if necessary.
The text was updated successfully, but these errors were encountered: