x/tools/gopls: analysis pass is run with missing inputs after one of its dependencies failed => crash #54798
Labels
FrozenDueToAge
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
When patching https://go-review.git.corp.google.com/c/tools/+/426018/7/internal/lsp/cache/analysis.go, which disables panic recovery, we find a number of nondeterministic panics including this one:
https://source.cloud.google.com/results/invocations/48b434a2-c9e7-46a9-acde-57b5fc976081/targets/golang%2Ftools%2Fgopls-legacy%2Fpresubmit-116/log
I believe the cause is that errors from analysis dependencies are treated as successful results because of sloppy handling of the distinction between
(*actionData=nil, err!=nil)
and(&actionData{err != nil}, err=nil)
.The text was updated successfully, but these errors were encountered: