Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: strip *.dylib from bareLDFLAGS #5479

Closed
gopherbot opened this issue May 15, 2013 · 4 comments
Closed

cmd/go: strip *.dylib from bareLDFLAGS #5479

gopherbot opened this issue May 15, 2013 · 4 comments
Labels
FrozenDueToAge

Comments

@gopherbot
Copy link

by rustf3:

Cgo linking behaviour has changed from go1.03 to go1.1 such that
   #cgo darwin LDFLAGS: libxx.dylib -framework Cocoa
used to work, but now fails with:
   ld: warning unexpected dylib (libxx.dylib) on link line

The workaround is a simple change to:
   #cgo darwin LDFLAGS: -lxx -framework Cocoa

I would have expected either:
   1) a mention in the go1.1 release notes regarding the change in behaviour, or
   2) the darwin specific LDFLAGS filter, created as part of issue #5822049 in src/cmd/go/build.go (for -l and -framework), to also filter standalone  dylibs.

(OSX 10.8.3, golang 1.1)
@minux
Copy link
Member

minux commented May 15, 2013

Comment 1:

https://golang.org/cl/9416047

Labels changed: added priority-soon, removed priority-triage.

Owner changed to @minux.

Status changed to Started.

@bradfitz
Copy link
Contributor

Comment 2:

Tentatively flagging as Go1.1.1. Others can decide.

Labels changed: added go1.1.1.

@minux
Copy link
Member

minux commented May 21, 2013

Comment 3:

This issue was closed by revision bea7b51.

Status changed to Fixed.

@ianlancetaylor
Copy link
Contributor

Comment 4:

Labels changed: removed go1.1.1.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bradfitz @minux @ianlancetaylor @gopherbot