-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: upgrade netbsd-386 and netbsd-amd64 builders to pick up recent libpthread
fixes
#54773
Comments
I think sending a CL to bump the version in x/build would be the desired path. |
Change https://go.dev/cl/428415 mentions this issue: |
Per #50138 (comment), we should upgrade the NetBSD builders to a post-9.3 build that includes the |
libpthread
fixes
The packages are taken from the 2022Q2 branch. These are built for the 9.0 release, as is usual upstream, but all 9.x releases are binary compatible. There are a few other refactorings in this CL to make future maintenance simpler. Update golang/go#54773 Change-Id: I38a8eab1aabd9985771ac83da2e435e490b7e4b4 Reviewed-on: https://go-review.googlesource.com/c/build/+/428415 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Run-TryBot: Benny Siegert <bsiegert@gmail.com> Reviewed-by: Carlos Amedee <carlos@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com>
Change https://go.dev/cl/450235 mentions this issue: |
This adds the 9.3 builders created by running the make file and manually uploading and creating the VM images. Updates golang/go#54773 Change-Id: I0826b1fea1c486ec7cb34abad539672bddc39bb7 Reviewed-on: https://go-review.googlesource.com/c/build/+/450235 Run-TryBot: Carlos Amedee <carlos@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Joedian Reid <joedian@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Change https://go.dev/cl/450615 mentions this issue: |
Change https://go.dev/cl/450715 mentions this issue: |
…ersion This change removed the known issue from the NetBSD 9.3 builders. It also promotes 9.3 to be the primary version of NetBSD used in the build infrastructure. Updates golang/go#54773 Change-Id: If8b8aa89edb9ed8be564149ea728715b4a7b1085 Reviewed-on: https://go-review.googlesource.com/c/build/+/450715 Run-TryBot: Carlos Amedee <carlos@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Jenny Rakoczy <jenny@golang.org> Reviewed-by: Benny Siegert <bsiegert@gmail.com>
This may help to diagnose whether the hang observed in https://build.golang.org/log/d03db1d27515a4f7e91502e8b58bc83f6e2c04be is related to #56180. Updates #56180. Updates #54773. Change-Id: I81d37e55a35f876905ceabc103fcf0d1ff348e2f Reviewed-on: https://go-review.googlesource.com/c/go/+/450615 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> Auto-Submit: Bryan Mills <bcmills@google.com>
@bsiegert, is there anything remaining to be done for this? (Do the older builders still need to be turned down, or configured to only run on release branches?) |
Yes, the *-9_0 builders should be turned down. Should I send a CL removing them from the dashboard? |
@bsiegert It would be great if you did. Thank you. |
Change https://go.dev/cl/454755 mentions this issue: |
There are a few ongoing issues that are potentially related to kernel bugs in NetBSD (possibly related to #50496).
There was a new NetBSD stable release, 9.3, that fixes a large number of such bugs. Perhaps some of the hard-to-diagnose bugs that keep cropping up have been actually fixed upstream. (I certainly hope so!)
I can send a CL to bump the versions in /x/build. However, as I remember, at some point, a member of @golang/release needs to actually create the image, or I can do that on a corp workstation and provide a link to an image.
/cc @golang/netbsd
The text was updated successfully, but these errors were encountered: