Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages: TestIssue32814/Modules is flaky #54751

Closed
heschi opened this issue Aug 29, 2022 · 2 comments
Closed

x/tools/go/packages: TestIssue32814/Modules is flaky #54751

heschi opened this issue Aug 29, 2022 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@heschi
Copy link
Contributor

heschi commented Aug 29, 2022

2022-08-24T18:36:56-587a153-8188bf6/windows-amd64-longtest-newcc
2022-08-24T18:08:33-587a153-b60432d/windows-amd64-2016
2022-08-24T17:56:56-587a153-cfae70c/windows-amd64-2016-newcc
2022-08-24T17:12:07-587a153-8a86b94/windows-amd64-longtest
2022-08-24T15:37:38-587a153-d5aa088/linux-amd64-nocgo
2022-08-24T14:31:08-587a153-f983a93/windows-386-2008
2022-08-24T12:12:12-587a153-b5a9459/windows-amd64-longtest
2022-08-24T08:17:52-587a153-1ab6b79/linux-amd64-clang
2022-08-24T08:17:52-587a153-1ab6b79/windows-amd64-longtest
2022-08-23T20:00:03-587a153-e1114fd/aix-ppc64
2022-08-19T17:47:49-e55fb40-a73808e/windows-amd64-2016
2022-08-19T17:47:49-e55fb40-a73808e/windows-amd64-longtest
2022-08-19T17:28:00-e55fb40-0a1da09/windows-amd64-2016
2022-08-19T16:17:50-e55fb40-5729419/linux-arm64-aws
2022-08-19T16:17:50-e55fb40-5729419/windows-386-2008-newcc
2022-08-19T16:12:50-e55fb40-3204e62/linux-amd64-unified
2022-08-19T16:12:50-e55fb40-3204e62/windows-amd64-longtest-newcc
2022-08-19T03:32:27-e55fb40-6001c04/windows-amd64-2016-newcc
2022-08-19T03:09:05-e55fb40-a409356/windows-amd64-longtest-newcc
2022-08-19T01:34:22-e55fb40-ee833ed/windows-amd64-2016
2022-08-19T01:34:22-e55fb40-ee833ed/windows-amd64-longtest-newcc
2022-08-19T01:31:59-e55fb40-e51b3ae/linux-s390x-ibm

--- FAIL: TestIssue32814 (0.00s)
    --- FAIL: TestIssue32814/Modules (5.67s)
        packages_test.go:2038: Errors for fmt pkg: got [C:\workdir\go\src\fmt\print.go:383:29: v.Type().String undefined (type reflect.Type has no field or method String)], want none
FAIL

cc @golang/tools-team
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Aug 29, 2022
@heschi heschi added NeedsFix The path to resolution is known, but the work has not been done. and removed Tools This label describes issues relating to any tools in the x/tools repository. labels Aug 29, 2022
@gopherbot gopherbot added this to the Unreleased milestone Aug 29, 2022
@heschi heschi added the Tools This label describes issues relating to any tools in the x/tools repository. label Aug 29, 2022
@heschi heschi mentioned this issue Aug 29, 2022
Closed
@findleyr
Copy link
Contributor

It looks like the failures stopped on 8/24.

@mdempsky, was this fixed by https://go.dev/cl/425362? Seems likely.

@mdempsky
Copy link
Member

Yeah, seems likely to me too. The date range starts around when GOEXPERIMENT=unified was enabled by default, and then stops around when we added that fix, which was being caught on the race-detector bots.

@golang golang locked and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@mdempsky @gopherbot @heschi @findleyr