Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net: missing 'net' import breaks z/OS build #54676

Closed
MacMalainey opened this issue Aug 25, 2022 · 3 comments
Closed

x/net: missing 'net' import breaks z/OS build #54676

MacMalainey opened this issue Aug 25, 2022 · 3 comments
Labels
arch-s390x Issues solely affecting the s390x architecture. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@MacMalainey
Copy link

A change was introduced in this commit that breaks the build of x/net/ipv6 (and any packages that end up depending on golang.org/x/net/internal/socket) on IBM z/OS.

The build error that occurs is when trying to build x/net/ipv6:

# golang.org/x/net/internal/socket
/home/macmala/go/pkg/mod/golang.org/x/net@v0.0.0-20220822230855-b0a4917ee28c/internal/socket/sys_zos_s390x.go:30:116: undefined: net
/home/macmala/go/pkg/mod/golang.org/x/net@v0.0.0-20220822230855-b0a4917ee28c/internal/socket/sys_zos_s390x.go:53:58: undefined: net

Cause:
The net package is used but not imported in the file internal/socket/sys_zos_s390x.go.

Verification:
When the net package is added as an import the package golang.org/x/net/internal/socket builds and all tests pass on IBM z/OS.

Requested action:
Add the net package as an import in the file internal/socket/sys_zos_s390x.go
@gopherbot gopherbot added this to the Unreleased milestone Aug 25, 2022
@ianlancetaylor
Copy link
Contributor

Sorry about that. Sent https://go.dev/cl/425534.

@gopherbot
Copy link

Change https://go.dev/cl/425534 mentions this issue: internal/socket: add missing import to zos-s390x file

@gopherbot
Copy link

Change https://go.dev/cl/425697 mentions this issue: internal/socket: add missing import to zos-s390x file

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. arch-s390x Issues solely affecting the s390x architecture. labels Aug 26, 2022
@dmitshur dmitshur reopened this Aug 26, 2022
WeiminShang added a commit to WeiminShang/net that referenced this issue Nov 16, 2022
@WeiminShang @dr2chase
internal/socket: add missing import to zos-s390x file
712537b 
Redo of go.dev/cl/425534, but w/o accidental binary file.

Fixes golang/go#54676

Change-Id: I69de5bd49f8d5be6d263b7eef0f491aba992bdbe
Reviewed-on: https://go-review.googlesource.com/c/net/+/425697
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: David Chase <drchase@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@golang golang locked and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-s390x Issues solely affecting the s390x architecture. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @ianlancetaylor @gopherbot @MacMalainey