Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/internal/relui/sign: fix flaky TestUpdateSigningStatusError test #54654

Open
cagedmantis opened this issue Aug 24, 2022 · 1 comment
Open

x/build/internal/relui/sign: fix flaky TestUpdateSigningStatusError test #54654

cagedmantis opened this issue Aug 24, 2022 · 1 comment
Assignees
@cagedmantis
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Backlog

Comments

@cagedmantis
Copy link
Contributor

cagedmantis commented Aug 24, 2022 •
edited

The TestUpdateSigningStatusError/non-existant_signing_request is flaky with the following error:

panic: Log in goroutine after TestUpdateSigningStatusError/non-existant_signing_request has completed: client.stream.Recv() = nil, rpc error: code = Unavailable desc = error reading from server: EOF; want no error

goroutine 46 [running]:
testing.(*common).logDepth(0x1400008b860, {0x140004280e0, 0x6e}, 0x3)
	/tmp/buildlet/go/src/testing/testing.go:887 +0x3d8
testing.(*common).log(...)
	/tmp/buildlet/go/src/testing/testing.go:869
testing.(*common).Logf(0x1400008b860, {0x104e8775a?, 0x1400009d2c0?}, {0x14000515fb0?, 0x0?, 0x2?})
	/tmp/buildlet/go/src/testing/testing.go:920 +0x5c
golang.org/x/build/internal/relui/sign.fakeSigningServerClient.func1()
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/relui/sign/server_test.go:105 +0x158
created by golang.org/x/build/internal/relui/sign.fakeSigningServerClient
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/relui/sign/server_test.go:94 +0x158
FAIL	golang.org/x/build/internal/relui/sign	0.170s

Observed in: https://build.golang.org/log/85793ca6714b307dbbd1a44772ec99a26d40f71f

@golang/release
@cagedmantis cagedmantis added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Aug 24, 2022
@cagedmantis cagedmantis added this to the Backlog milestone Aug 24, 2022
@cagedmantis cagedmantis self-assigned this Aug 24, 2022
@dmitshur dmitshur changed the title internal/relui/sign: fix flaky TestUpdateSigningStatusError test x/build/internal/relui/sign: fix flaky TestUpdateSigningStatusError test Aug 24, 2022
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Aug 24, 2022
@gopherbot
Copy link

Change https://go.dev/cl/425359 mentions this issue: internal/relui/sign: skip flaky test TestUpdateSigningStatusError

gopherbot pushed a commit to golang/build that referenced this issue Aug 25, 2022
@cagedmantis @gopherbot
internal/relui/sign: skip flaky test TestUpdateSigningStatusError
1d544f3 
This skips the
TestUpdateSigningStatusError/non-existant_signing_request test.

Updates golang/go#54654

Change-Id: I0db94e95cdd6a6ad25696ea7029fbf93f9092d66
Reviewed-on: https://go-review.googlesource.com/c/build/+/425359
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
@heschi heschi mentioned this issue Aug 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagedmantis cagedmantis

Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@cagedmantis @dmitshur @gopherbot