Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/modfetch/codehost: racing writes to Origin fields [1.19 backport] #54633

Closed
gopherbot opened this issue Aug 23, 2022 · 3 comments
Closed

cmd/go/internal/modfetch/codehost: racing writes to Origin fields [1.19 backport] #54633

gopherbot opened this issue Aug 23, 2022 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go modules
Milestone
Go1.19.1

Comments

@gopherbot
Copy link

@bcmills requested issue #54631 to be considered for backport to the next 1.19 minor release.

@gopherbot, please backport to Go 1.19. This is a data race introduced in CL 411397 late in the Go 1.19 cycle.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 23, 2022
@gopherbot gopherbot mentioned this issue Aug 23, 2022
Closed
@gopherbot gopherbot added this to the Go1.19.1 milestone Aug 23, 2022
@bcmills bcmills changed the title cmd/go/internal/modfetch/codehost: data race in (*gitRepo).Latest [1.19 backport] cmd/go/internal/modfetch/codehost: racing writes to Origin fields [1.19 backport] Aug 24, 2022
@bcmills
Copy link
Contributor

bcmills commented Aug 24, 2022

This is a data race affecting cmd/go (not just tests), and the race was introduced late in the Go 1.19 cycle. Approving.

@bcmills bcmills added CherryPickApproved Used during the release process for point releases GoCommand cmd/go modules labels Aug 24, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 24, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/425211 mentions this issue: [release-branch.go1.19] cmd/go: avoid overwriting cached Origin metadata

@gopherbot
Copy link
Author

Closed by merging d2bcb22 to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Aug 29, 2022
@heschi
[release-branch.go1.19] cmd/go: avoid overwriting cached Origin metadata
d2bcb22 
Fixes #54633.
Updates #54631.

Change-Id: I17d2fa282642aeb1ae2a6e29a0756b8960bea34b
Reviewed-on: https://go-review.googlesource.com/c/go/+/425255
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
(cherry picked from commit e3004d96b6899945d76e5dd373756324c8ff98fb)
Reviewed-on: https://go-review.googlesource.com/c/go/+/425211
bradfitz pushed a commit to tailscale/go that referenced this issue Sep 8, 2022
@bradfitz
[release-branch.go1.19] cmd/go: avoid overwriting cached Origin metadata
ec75b7d 
Fixes golang#54633.
Updates golang#54631.

Change-Id: I17d2fa282642aeb1ae2a6e29a0756b8960bea34b
Reviewed-on: https://go-review.googlesource.com/c/go/+/425255
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
(cherry picked from commit e3004d96b6899945d76e5dd373756324c8ff98fb)
Reviewed-on: https://go-review.googlesource.com/c/go/+/425211
@golang golang locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go modules
Projects
None yet
Milestone
Go1.19.1
Development

No branches or pull requests
2 participants
@bcmills @gopherbot