Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/test: TestCommandLine/GOPATH/Renames/b_Goodbye failure with apply unified gave wrong result #54601

Closed
bcmills opened this issue Aug 22, 2022 · 2 comments
Closed

x/tools/gopls/test: TestCommandLine/GOPATH/Renames/b_Goodbye failure with apply unified gave wrong result #54601

bcmills opened this issue Aug 22, 2022 · 2 comments
Assignees
@pjweinb
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 22, 2022 

            --- FAIL: TestCommandLine/GOPATH/Renames/b_Goodbye (0.28s)
                rename.go:24: rename failed with /ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/TestCommandLine_GOPATH3623923662/lsp/src/golang.org/x/tools/internal/lsp/rename/b/b.go:20:6-11 Goodbye
…
                format.go:84: apply unified gave wrong result for /ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/TestCommandLine_GOPATH3623923662/lsp/src/golang.org/x/tools/internal/lsp/rename/b/b.go expected:
                    b.go:
                    package b

greplogs -l -e 'apply unified gave wrong result' --since=2022-02-01
2022-08-11T14:11:53-3807419-2340d37/aix-ppc64
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Aug 22, 2022
@gopherbot gopherbot added this to the Unreleased milestone Aug 22, 2022
@bcmills bcmills changed the title x/tools/gopls/test: TestCommandLine/GOPATH/Renames/b_Goodbye failure with `apply unified gave wrong result' x/tools/gopls/test: TestCommandLine/GOPATH/Renames/b_Goodbye failure with apply unified gave wrong result Aug 22, 2022
@bcmills bcmills mentioned this issue Aug 22, 2022
Closed
@suzmue suzmue modified the milestones: Unreleased, gopls/v0.10.0 Aug 22, 2022
@findleyr findleyr modified the milestones: gopls/v0.10.0, gopls/v0.10.1 Sep 1, 2022
@findleyr findleyr modified the milestones: gopls/v0.10.1, gopls/v0.10.2 Nov 1, 2022
@findleyr findleyr modified the milestones: gopls/v0.11.0, gopls/v0.12.0 Dec 8, 2022
@findleyr
Copy link
Contributor

CC @pjweinb @adonovan : is this a dupe of our previous bug in ApplyUnified, which I think is fixed?

@adonovan
Copy link
Member

is this a dupe of our previous bug in ApplyUnified, which I think is fixed?

Perhaps? In any case, this failure hasn't been observed in the builder or otherwise for 6 months. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjweinb pjweinb

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.12.0
Development

No branches or pull requests
6 participants
@bcmills @pjweinb @adonovan @suzmue @gopherbot @findleyr