Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: only show Check for upgrades diagnostics to containing go.mod file #54556

Closed
suzmue opened this issue Aug 19, 2022 · 1 comment
Closed

x/tools/gopls: only show Check for upgrades diagnostics to containing go.mod file #54556

suzmue opened this issue Aug 19, 2022 · 1 comment
Assignees
@suzmue
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.10.0

Comments

@suzmue
Copy link
Contributor

suzmue commented Aug 19, 2022

I am using go.work to develop gopls. The contents of my go.work are:

go 1.18

use (
	.
	./gopls
)

I clicked on the Check for upgrades codelens in x/tools/go.mod

I would expect to see either (1) all of the upgrade diagnostics in both files, or (2) only diagnostics on x/tool/go.mod

Instead I saw upgrade diagnostics in both files, but the diagnostics in x/tools/gopls/go.mod only included dependencies that were also in x/tools/go.mod. There were additional upgrades available in x/tools/gopls/go.mod but the diagnostics were not shown.

Screen Shot 2022-08-18 at 11 16 26 AM
@suzmue suzmue self-assigned this Aug 19, 2022
@suzmue suzmue added the gopls Issues related to the Go language server, gopls. label Aug 19, 2022
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Aug 19, 2022
@gopherbot gopherbot added this to the Unreleased milestone Aug 19, 2022
@suzmue suzmue added this to the gopls/v0.10.0 milestone Aug 19, 2022
@gopherbot
Copy link

Change https://go.dev/cl/425195 mentions this issue: internal/lsp: add diagnostics for all workspace modules

@suzmue suzmue changed the title x/tools/gopls: check dependencies for all modules in the workspace when checking for upgrades. x/tools/gopls: only show Check for upgrades diagnostics to containing go.mod file Aug 23, 2022
@golang golang locked and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@suzmue suzmue

Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.10.0
Development

No branches or pull requests
2 participants
@suzmue @gopherbot