Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: bsd-4-clause link is broken #54540

Closed
willfaught opened this issue Aug 19, 2022 · 3 comments
Closed

x/pkgsite: bsd-4-clause link is broken #54540

willfaught opened this issue Aug 19, 2022 · 3 comments
Labels
FrozenDueToAge pkgsite
Milestone
Unreleased

Comments

@willfaught
Copy link
Contributor

What is the URL of the page with the issue?

https://pkg.go.dev/license-policy

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.6 Safari/605.1.15

Screenshot

Screen Shot 2022-08-18 at 8 27 50 PM

What did you do?

What did you expect to see?

Links work

What did you see instead?

404

The links are https://opensource.org/licenses/BSD-4-Clause and https://opensource.org/licenses/BSD-4-Clause-UC.

What were probably intended were https://spdx.org/licenses/BSD-4-Clause.html and https://spdx.org/licenses/BSD-4-Clause-UC.html.
@gopherbot gopherbot added this to the Unreleased milestone Aug 19, 2022
@willfaught
Copy link
Contributor Author

willfaught commented Aug 19, 2022 •
edited

More:

I guess just test them all.

@kucukaslan
Copy link
Contributor

It seems those licenses are not OSI approved licences1 but the pkgsite generates the URLs as if they're OSI approved. I think adding them to nonOSILicenses map in the website source code would fix it. I'll give it a try and open a PR to fix.

Footnotes

  1. https://opensource.org/licenses/alphabetical ↩

kucukaslan added a commit to kucukaslan/pkgsite that referenced this issue Aug 24, 2022
@kucukaslan
internal/licenses: update the list of licenses not approved by OSI
d5cae3e 
The URLs of some of the licenses that are not approved by OSI were directing to nonexisting pages in opensource.org. This commit fixes them

Fixes golang/go#54540
@kucukaslan kucukaslan mentioned this issue Aug 24, 2022
Closed
@gopherbot
Copy link

Change https://go.dev/cl/425368 mentions this issue: internal/licenses: update the list of licenses not approved by OSI

@golang golang locked and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge pkgsite
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

internal/licenses: update the list of licenses not approved by OSI kucukaslan/pkgsite
3 participants
@willfaught @gopherbot @kucukaslan