-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: internal compiler error: expression has untyped type #54537
Comments
Build passed when GOEXPERIMENT=nounified |
cc @mdempsky |
Minimal reproducer:
|
In the
That looks right to me. I think the issue is that walk is desugaring the OEQ expression into an "untyped bool" expression; and then somewhere we decide whether to convert it to the original type (go.shape.bool), but types.Identical reports them as identical so we skip coercing back to go.shape.bool. Probably the fix is to ensure the conversion from "untyped bool" to "go.shape.bool" really happens as needed. |
I think the issue is the typecheck.Conv call in walk.finishCompare. Probably we want to change the types.Identical calls to types.IdenticalStrict. |
Yeah, for nounified, at that stage, |
The issue affects nounified too: https://go.dev/play/p/BKYr_UUMGvH |
Change https://go.dev/cl/424936 mentions this issue: |
Change https://go.dev/cl/424937 mentions this issue: |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
tip only
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
Build hashicorp/nomad
Trying to find minimal reproduction.
What did you expect to see?
Build successful
What did you see instead?
The text was updated successfully, but these errors were encountered: