Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/poll: can update newPipe to take advantage of newer Linux kernel requirement #54505

Closed
dmitshur opened this issue Aug 17, 2022 · 1 comment
Closed

internal/poll: can update newPipe to take advantage of newer Linux kernel requirement #54505

dmitshur opened this issue Aug 17, 2022 · 1 comment
Assignees
@tklauser
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.20

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Aug 17, 2022 •
edited

newPipe currently contains this comment:

// pipe2 was added in 2.6.27 and our minimum requirement is 2.6.23, so it
// might not be implemented. Falling back to pipe is possible, but prior to
// 2.6.29 splice returns -EAGAIN instead of 0 when the connection is
// closed.

(src/internal/poll/splice_linux.go#220-223)

It was added in 2018 to fix #25486.

As of proposal #45964, the minimum kernel that needs to be supported is 2.6.32, so there may be an opportunity to take advantage of that. If there's nothing to do differently, the comment can be deleted since pipe2 will now always be available and there's no need to explain why to avoid fallback to pipe.

CC @ianlancetaylor, @bradfitz, @tklauser.
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 17, 2022
@dmitshur dmitshur added this to the Backlog milestone Aug 17, 2022
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 17, 2022
@gopherbot
Copy link

Change https://go.dev/cl/422979 mentions this issue: internal/poll: remove detection of buggy splice on old Linux versions

@dmitshur dmitshur modified the milestones: Backlog, Go1.20 Aug 18, 2022
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 18, 2022
@tklauser tklauser self-assigned this Mar 21, 2023
@golang golang locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tklauser tklauser

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.20
Development

No branches or pull requests
3 participants
@tklauser @dmitshur @gopherbot