cc @golang/release

Hi, I've been working on several CLs recently, it would be a great help if this process could be expedited, thanks~

Hi Andy,

Thank you for your contributions! After some discussion, we decided that it's too early for Approvers access -- we appreciate all the cleanup work, but it doesn't form a large enough history for us to evaluate. However, we're very happy to give you TryBot access. I've added you to the may-start-trybots group, so you should be able to do that now.

As you've likely read at https://golang.org/wiki/GerritAccess#trybot-access-may-start-trybots, please be sure to at least skim CLs before starting a Trybot run.

Let us know if you have any questions or issues with it, and thanks again!

Hi @heschi , sorry to hear that, I believe I used to do more than just trivial cleanup work, but also feature development, performance optimization and bug fixing, so I wonder what specific prerequisites are needed before I can officially apply for go-approver access? I request go-approvers access to merge my own CLs after they are given +2 vote by at least two Google staff (according to the latest policy of Go team, which I will strictly abide by), sometimes the approvers are just too busy to merge CLs which is ready to be merged after they give +2 votes, and I hate to bother them over and over again until my CLs get merged.

Besides, I was also requesting to be in https://github.com/orgs/golang/teams/go-approvers for https://go.dev/wiki/Gardening and https://github.com/golang/go/wiki/HandlingIssues, as a member of https://github.com/orgs/golang, helping handle some Github issues, please also take a look at this request, thank you!

@panjf2000 An approvers grant is normally reserved for people whose CLs are routinely approved with no comments. I don't think your CLs are at that point yet. Sorry.

Issue gardening doesn't require approvers access, as the issues are managed in GitHub, not Gerrit. It's a bit confusing, as the GitHub name is "go-approvers" (not "approvers") for some reason.. I sent you an invitation to the GitHub group.

Hi all,
I'd like to reapply for the Code-Review+2 permission at this point.

I've had a few pending submissions lately, along with a series of pending CLs locally (haven't uploaded yet). It would really help me expedite my work on Gerrit if I have permission to submit CLs that have gained sufficient votes. Thanks!

cc @golang/release

Change https://go.dev/cl/560255 mentions this issue: devapp/owners: add @panjf2000 as owner for the net and net/http

Ping @golang/release

Hi @golang/release, I have a few new ready-to-submit CLs recently and my request for +2 permission has been around for quite a while, I wonder what its current status is?

Hi @panjf2000, thanks for contributing to the Go project and asking for approvers access again.

We considered this request. As documented at https://go.dev/wiki/GerritAccess, Gerrit "approvers" access permits reviewing and submitting CLs across the entire Go project, and I know you've expressed in helping with net and net/http package maintenance in particular. It's a high bar to clear to get access to leave +2 reviews, and your contribution history is not currently at a point where we can confidently grant it. We'll decline this request for now, but please feel free to reapply after some time.

For CLs that you've authored that have a +2 Code-Review vote and are ready to be submitted from your side, please don't hesitate to ask the person who left the +2 vote to submit your CL (or to leave an Auto-Submit+1 vote if you don't anticipate needing to push additional patch sets, e.g., if it's just waiting for the last trybot run). Thanks again.

@panjf2000 The Auto-Submit+1 vote is documented at https://go.dev/wiki/GerritAccess#auto-submit. I meant you can ask the person who left the Code-Review+2 vote to either submit or leave Auto-Submit+1 vote—but it needs to be done by someone who is an approver.

It's a high bar to clear to get access to leave +2 reviews, and your contribution history is not currently at a point where we can confidently grant it.

To be frank, I can understand setting the "high bar" for +2 permission, it's just that the criteria for that threshold have always seemed unclear to me. I've been constantly contributing over 120 commits to the Go project across net, net/http, runtime, os, internal/poll, log/slog, encoding, etc. and participating in resolving GitHub issues for almost five years. If that still can't suffice to qualify me, I believe I must haven't been doing things right. Please show me what I have done wrong and point me in the right direction so that I can be on the track of earning a +2 permission afterward.

I guess what I'm trying to figure out is how far I am to the +2 permission, because at this moment I really can't tell what more I have to do before I should reapply again, or when to do it.