Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/text: needs maintainer #54481

Open
golightlyb opened this issue Aug 16, 2022 · 12 comments
Open

x/text: needs maintainer #54481

golightlyb opened this issue Aug 16, 2022 · 12 comments
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone

Comments

@golightlyb
Copy link
Contributor

golightlyb commented Aug 16, 2022

@mpvl is listed as as owner of x/text, and appears to have been the main author, but doesn't appear to have worked on anything related to Go on GitHub or Gerrit for over a year. I am a big fan of mpvl's work in x/text but it's half finished and I don't know if any hand off was successful.

There are many Go programmers with an interest in localisation. Could an experienced maintainer coordinate a working group perhaps?

See also #12750.

@gopherbot gopherbot added this to the Proposal milestone Aug 16, 2022
@seankhliao
Copy link
Member

Or we can deprecate it like x/crypto/openpgp

@ianlancetaylor
Copy link
Contributor

This is in the proposal track but I'm not sure it's really a proposal. I agree that it would be nice if x/text had an active maintainer, but the proposal review committee can't cause that to somehow happen.

There are many Go programmers with an interest in localisation. Could an experienced maintainer coordinate a working group perhaps?

That seems a potentially more profitable avenue to pursue, but again isn't really in the purview of the proposal committee.

@golightlyb golightlyb changed the title proposal: x/text: needs maintainer x/text: needs maintainer Aug 17, 2022
@golightlyb
Copy link
Contributor Author

golightlyb commented Aug 17, 2022

Thank you - I didn't know to what extent this was the case. I've edited to make this a regular issue instead. Please remove from the milestone.

@fgm
Copy link

fgm commented Aug 17, 2022

I discussed that at Gophercon EU with @thanm, as I am actually interested in working on this for our own needs. However, for now, I still haven't managed to untangle how to build updates.

@thanm
Copy link
Contributor

thanm commented Aug 17, 2022

@fgm good to hear that you are interested. For building updates, I think there is a CL https://go-review.git.corp.google.com/c/text/+/304029 that needs to move forward. I'll talk with folks about that.

@thanm
Copy link
Contributor

thanm commented Aug 17, 2022

OK, https://go-review.git.corp.google.com/c/text/+/304029 is now submitted. @fgm I think you should be able to build updates now (if not let me know and I can try to help).

@golightlyb
Copy link
Contributor Author

Really glad there's movement on this.

When it comes to CLs in x/text, is there a reviewer with +2 approval powers we can cc for attention? (I understand we need at least two +1s from Google staff?)

@thanm
Copy link
Contributor

thanm commented Sep 6, 2022

@golightlyb you can CC me on reviews for the time being, I can pull in other folks from the team where needed.

@fgm, are you unblocked at this point?

@fgm
Copy link

fgm commented Sep 8, 2022 via email

@thanm
Copy link
Contributor

thanm commented Sep 8, 2022

Thanks, no hurry, just wanted to check in.

@rsc rsc removed the Proposal label Sep 21, 2022
@rsc rsc modified the milestones: Proposal, Backlog Sep 21, 2022
@rsc rsc added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Sep 21, 2022
@rsc
Copy link
Contributor

rsc commented Sep 21, 2022

Taking out of proposal process. It's not really a language or library change proposal. @mpvl agrees that having a new maintainer would be good, but that person is signing up for a lot of subtle algorithms. :-)

@fgm
Copy link

fgm commented Oct 6, 2022

Update: been working on the various RFCs and associated tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Development

No branches or pull requests

7 participants