Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go get cannot create zip #54384

Closed
uhthomas opened this issue Aug 10, 2022 · 3 comments
Closed

cmd/go: go get cannot create zip #54384

uhthomas opened this issue Aug 10, 2022 · 3 comments
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.

Comments

@uhthomas
Copy link

What version of Go are you using (go version)?

$ go version
1.19

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/root/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/root/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/nix/store/wc4py67prnfb5izkvwjpn4v53vzi1amk-go-1.19/share/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/nix/store/wc4py67prnfb5izkvwjpn4v53vzi1amk-go-1.19/share/go/pkg/tool/linux_arm64"
GOVCS=""
GOVERSION="go1.19"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -pthread -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3183675079=/tmp/go-build -gno-record-gcc-switches"

What did you do?

go get -d github.com/sourcegraph/sourcegraph@f659e61

What did you expect to see?

A successful download.

What did you see instead?

root@b64f345f7401:/# go get -d github.com/sourcegraph/sourcegraph@f659e61
go: downloading github.com/sourcegraph/sourcegraph v0.0.0-20220805202456-f659e618d762
go: github.com/sourcegraph/sourcegraph@f659e61: create zip: internal/search/query/testdata/TestParseStandard/patterns_are_literal_and_slash-delimited_patterns_/.../_are_regexp.golden: malformed file path "internal/search/query/testdata/TestParseStandard/patterns_are_literal_and_slash-delimited_patterns_/.../_are_regexp.golden": invalid path element "..."

The problem file: https://github.com/sourcegraph/sourcegraph/tree/6cf24568ac2c070f96ab9fed5470a2d26f088315/internal/search/query/testdata/TestParseStandard/patterns_are_literal_and_slash-delimited_patterns_/...

Although weird, I don't see anything "wrong" with this. A directory named "..." is fine with Linux and fine with Go's archive/tar package.

@uhthomas
Copy link
Author

Sort of related? #45549

@mengzhuo mengzhuo added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Aug 11, 2022
@mengzhuo
Copy link
Contributor

cc @bcmills @matloob

@seankhliao
Copy link
Member

Duplicate of #45549

@seankhliao seankhliao marked this as a duplicate of #45549 Aug 11, 2022
@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2022
@golang golang locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Development

No branches or pull requests

4 participants