Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: internal compiler error: panic: runtime error: invalid memory address or nil pointer dereference [1.19 backport] #54309

Closed
gopherbot opened this issue Aug 5, 2022 · 6 comments
Closed

cmd/compile: internal compiler error: panic: runtime error: invalid memory address or nil pointer dereference [1.19 backport] #54309

gopherbot opened this issue Aug 5, 2022 · 6 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.19.1

Comments

@gopherbot
Copy link

@mdempsky requested issue #54302 to be considered for backport to the next 1.19 minor release.

@gopherbot Please backport to Go 1.19. This is a regression from Go 1.18.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 5, 2022
@gopherbot gopherbot mentioned this issue Aug 5, 2022
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 5, 2022
@gopherbot gopherbot added this to the Go1.19.1 milestone Aug 5, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/421715 mentions this issue: [release-branch.go1.19] cmd/compile: fix import/export of ODYNAMICDOTTYPE

@borzovplus
Copy link

Any updates? I have the same problem in 1.18.5 and in 1.19

@randall77
Copy link
Contributor

@borzovplus The fix will be available in 1.19.1 when it comes out (a few weeks). I'm not sure about whether this will be fixed in 1.18 or not. @mdempsky

@mdempsky
Copy link
Member

mdempsky commented Aug 8, 2022

Thanks. I've reopened #54308 to discuss 1.18 backport.

@borzovplus
Copy link

@borzovplus The fix will be available in 1.19.1 when it comes out (a few weeks). I'm not sure about whether this will be fixed in 1.18 or not. @mdempsky

oh, so long...

@joedian joedian added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Aug 10, 2022
@gopherbot
Copy link
Author

Closed by merging 3c200d6 to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Aug 11, 2022
@mdempsky @thanm
[release-branch.go1.19] cmd/compile: fix import/export of ODYNAMICDOT…
3c200d6 
…TYPE

The RType field isn't needed when performing type assertions from
non-empty interface types, because we use the ITab field instead. But
the inline body exporter didn't know to expect this.

It's possible we could use a single bool to distinguish whether
we're serializing the RType or ITab field, but using two is simpler
and seems safer.

Fixes #54309.

Change-Id: I9ddac72784fb2241fee0a0dee30493d868a2c259
Reviewed-on: https://go-review.googlesource.com/c/go/+/421755
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit 0c4db1e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/421715
Reviewed-by: Than McIntosh <thanm@google.com>
bradfitz pushed a commit to tailscale/go that referenced this issue Sep 8, 2022
@mdempsky @bradfitz
[release-branch.go1.19] cmd/compile: fix import/export of ODYNAMICDOT…
741e980 
…TYPE

The RType field isn't needed when performing type assertions from
non-empty interface types, because we use the ITab field instead. But
the inline body exporter didn't know to expect this.

It's possible we could use a single bool to distinguish whether
we're serializing the RType or ITab field, but using two is simpler
and seems safer.

Fixes golang#54309.

Change-Id: I9ddac72784fb2241fee0a0dee30493d868a2c259
Reviewed-on: https://go-review.googlesource.com/c/go/+/421755
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit 0c4db1e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/421715
Reviewed-by: Than McIntosh <thanm@google.com>
@golang golang locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.19.1
Development

No branches or pull requests
5 participants
@mdempsky @randall77 @gopherbot @joedian @borzovplus