Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/relui: better retry support #54304

Closed
heschi opened this issue Aug 5, 2022 · 2 comments
Closed

x/build/cmd/relui: better retry support #54304

heschi opened this issue Aug 5, 2022 · 2 comments
Assignees
@heschi
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@heschi
Copy link
Contributor

heschi commented Aug 5, 2022

Currently we can only retry a task if the workflow is stopped. Given the number of concurrent tasks going on these days, waiting for them all to finish is time-consuming, especially for minor releases where there are two big sub-workflows running. We should be able to retry tasks while the workflow runs.

cc @golang/release
@heschi heschi added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Aug 5, 2022
@heschi heschi added this to the Unreleased milestone Aug 5, 2022
@heschi heschi self-assigned this Aug 5, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/422098 mentions this issue: internal/workflow: add native retry support

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/423015 mentions this issue: cmd/relui: fix two silly mistakes

gopherbot pushed a commit to golang/build that referenced this issue Aug 12, 2022
@heschi
cmd/relui: fix two silly mistakes
8f8b3fc 
...only one of which was mine :)

- In retry, return an error if the workflow we're looking for is *not*
  found.
- During server startup, don't re-check err as if it was returned by
  NewServer.

For golang/go#54304.

Change-Id: I8429bd69bc5f344fe956efb00b59fdc844b92ced
Reviewed-on: https://go-review.googlesource.com/c/build/+/423015
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
@heschi heschi moved this to Done in Go Release Sep 27, 2022
@golang golang locked and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heschi heschi

Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @heschi