Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/internal/relui/protos: add the GRPC service for signing release artifacts. #54303

Closed
cagedmantis opened this issue Aug 5, 2022 · 4 comments
Closed

x/build/internal/relui/protos: add the GRPC service for signing release artifacts. #54303

cagedmantis opened this issue Aug 5, 2022 · 4 comments
Assignees
@cagedmantis
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Backlog

Comments

@cagedmantis
Copy link
Contributor

Relui should add a GRPC service to enable release artifact signing.

Part of #53632.

@golang/release
@cagedmantis cagedmantis added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 5, 2022
@cagedmantis cagedmantis added this to the Backlog milestone Aug 5, 2022
@cagedmantis cagedmantis self-assigned this Aug 5, 2022
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 5, 2022
@cagedmantis cagedmantis mentioned this issue Aug 5, 2022
Closed
1 task
@gopherbot
Copy link

Change https://go.dev/cl/420801 mentions this issue: internal/relui/protos: add protos to relui

@dmitshur dmitshur added this to In Progress in Go Release Team Aug 8, 2022
gopherbot pushed a commit to golang/build that referenced this issue Aug 9, 2022
@cagedmantis
internal/relui/protos: add protos to relui
a69abb0 
This change adds protos for release artifact signing.

Updates golang/go#54303

Change-Id: I9ff6645177a4b300023f842874fc8c2acb754c72
Reviewed-on: https://go-review.googlesource.com/c/build/+/420801
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/422598 mentions this issue: internal/relui/sign: add signing server

gopherbot pushed a commit to golang/build that referenced this issue Aug 18, 2022
@cagedmantis
internal/relui/sign: add signing server
046e1cd 
This change adds the signing server used to request artifact signing.
An interface has been added to the sign package in order to create
different implementations of the signing service if needed. With the
GRPC signing service, the client creates a bidirectional connection
with the server. The server then sends well specified signing requests
to the client.

Updates golang/go#54303
Updates golang/go#53632

Change-Id: I062f7db716edba810b6c1dab122b2a10c1c18923
Reviewed-on: https://go-review.googlesource.com/c/build/+/422598
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/424914 mentions this issue: cmd/relui: add the release GRPC server to the HTTP server

@gopherbot
Copy link

Change https://go.dev/cl/424915 mentions this issue: deploy: add Release GRPC server to build.golang.org

Go Release Team automation moved this from In Progress to Done Aug 19, 2022
gopherbot pushed a commit to golang/build that referenced this issue Aug 19, 2022
@cagedmantis
cmd/relui: add the release GRPC server to the HTTP server
7cf3efd 
This adds the GRPC release server to the main relui HTTP server.

Updates golang/go#53632
Updates golang/go#54303

Change-Id: I244ac02db1c2647e3f9f0f8f72a89467f07d1881
Reviewed-on: https://go-review.googlesource.com/c/build/+/424914
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
@golang golang locked and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cagedmantis cagedmantis

Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Backlog
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot