Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: cleanup timer codes #54287

Closed
wants to merge 2 commits into from
Closed

runtime: cleanup timer codes #54287

wants to merge 2 commits into from

Conversation

OmidHekayati
Copy link

The existing implementation has a poor structure and is a mess.
I just moved exist codes to seprated files and structures
to improve code and logic readability.
No logic has been changed in this cleanup.

Updates #53953

@OmidHekayati
runtime: cleanup timer codes
c324f92 
The existing implementation has a poor structure and is a mess.
I just moved exist codes to seprated files and structures
to improve code and logic readability.
No logic has been changed in this cleanup.

Updates #53953
@gopherbot
Copy link

This PR (HEAD: c324f92) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/421615 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/421615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Michael Knyszek:

Patch Set 1:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/421615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Omid Hekayati:

Patch Set 1:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/421615.
After addressing review feedback, remember to publish your drafts!

@OmidHekayati
runtime: fix PR review comments
127edfd 
- rename timer.add() to timer.start()
- rename timer.delete() to timer.stop()
- change atomic fields to atomic.[T]
@gopherbot
Copy link

This PR (HEAD: 127edfd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/421615 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Omid Hekayati:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/421615.
After addressing review feedback, remember to publish your drafts!

@OmidHekayati
Copy link
Author

I think it is the time we must close this issue and related PR as It will never ever have chance to merge. I suggest main Golang developers with enough power to change, work on /runtime/ package and move time and timer functionality to dedicate packages as /time/ and /timer/. In this case we will have /time/monotonic, /time/unix, ... packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OmidHekayati @gopherbot