Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/regtest/misc: TestFailingDiagnosticClearingOnEdit failures with "context deadline exceeded" #54271

Closed
dmitshur opened this issue Aug 4, 2022 · 1 comment
Closed

x/tools/gopls/internal/regtest/misc: TestFailingDiagnosticClearingOnEdit failures with "context deadline exceeded" #54271

dmitshur opened this issue Aug 4, 2022 · 1 comment
Assignees
@findleyr
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.9.2

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Aug 4, 2022

There are instances of the TestFailingDiagnosticClearingOnEdit test failing with "context deadline exceeded":

--- FAIL: TestFailingDiagnosticClearingOnEdit (560.80s)
    --- FAIL: TestFailingDiagnosticClearingOnEdit/default (560.80s)
        failures_test.go:63: waiting on:
            Met: no diagnostics for "a.go"
            Unmet: no diagnostics for "b.go"
            
            err:context deadline exceeded
            
            state:
            #### log messages (see RPC logs for full text):
            	Info: "2022/08/03 20:09:16 go env for /tmp/workdir/tmp/go...
            	Info: "2022/08/03 20:09:16 go/packages.Load #22\n\tsnapsh...
            	Info: "2022/08/03 20:09:16 go/packages.Load #22: updating...
            	Error: "2022/08/03 20:09:16 unable to compute positions f...
            	Error: "2022/08/03 20:09:16 unable to compute positions f...
            
            #### diagnostics:
            	b.go (version 1):
            
            #### outstanding work:
            #### completed work:
            	Load: 1
            	Setting up workspace: 1
            	diagnosing initial workspace load: 1
            	diagnosing opened files: 1
FAIL
FAIL	golang.org/x/tools/gopls/internal/regtest/misc	588.737s
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 4, 2022
@dmitshur dmitshur added this to the Unreleased milestone Aug 4, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Aug 4, 2022
@dmitshur dmitshur mentioned this issue Aug 5, 2022
Closed
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.9.2 Aug 8, 2022
@gopherbot
Copy link

Change https://go.dev/cl/422136 mentions this issue: gopls/internal/regtest: fix TestFailingDiagnosticClearingOnEdit

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 8, 2022
@findleyr findleyr self-assigned this Aug 9, 2022
@golang golang locked and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@findleyr findleyr

Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.9.2
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @findleyr