Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug/pe: riscv64 is not supported #54251

Closed
alfonsosanchezbeato opened this issue Aug 4, 2022 · 2 comments
Closed

debug/pe: riscv64 is not supported #54251

alfonsosanchezbeato opened this issue Aug 4, 2022 · 2 comments
Labels
arch-riscv Issues solely affecting the riscv64 architecture. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.20

Comments

@alfonsosanchezbeato
Copy link

What version of Go are you using (go version)?

$ go version
go version go1.18.1 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/abeato/.cache/go-build"
GOENV="/home/abeato/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/abeato/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/abeato/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go-1.18"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.18/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.18.1"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3245950783=/tmp/go-build -gno-record-gcc-switches"

What did you do?

IMAGE_FILE_MACHINE_RISCV64 is not supported in the debug/pe package. That should be a matter of simply adding a test for it in a couple of places, like in 0ca0551

What did you expect to see?

NA

What did you see instead?

NA
@alfonsosanchezbeato alfonsosanchezbeato mentioned this issue Aug 4, 2022
Merged
@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-riscv Issues solely affecting the riscv64 architecture. labels Aug 4, 2022
@dmitshur
Copy link
Contributor

dmitshur commented Aug 4, 2022

CC @alexbrainman, @golang/riscv64.

@dmitshur dmitshur added this to the Backlog milestone Aug 4, 2022
@mengzhuo mengzhuo changed the title debug/pe: RiscV64 is not supported debug/pe: riscv64 is not supported Aug 5, 2022
@gopherbot
Copy link

Change https://go.dev/cl/421357 mentions this issue: debug/pe: add IMAGE_FILE_MACHINE_RISCV64

@dmitshur dmitshur modified the milestones: Backlog, Go1.20 Aug 5, 2022
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 6, 2022
jproberts pushed a commit to jproberts/go that referenced this issue Aug 10, 2022
@mengzhuo @jproberts
debug/pe: add IMAGE_FILE_MACHINE_RISCV{32,64,128}
edd2d8e 
https://docs.microsoft.com/en-us/windows/win32/debug/pe-format

Fixes golang#54251

Change-Id: I024130fd9f55b2f1c0439baacdc56cdbc3315215
Reviewed-on: https://go-review.googlesource.com/c/go/+/421357
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Meng Zhuo <mzh@golangcn.org>
@prattmic prattmic mentioned this issue Dec 6, 2022
Closed
@golang golang locked and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-riscv Issues solely affecting the riscv64 architecture. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.20
Development

No branches or pull requests
3 participants
@dmitshur @alfonsosanchezbeato @gopherbot