Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: TestSimultaneousEdits flaking on Kokoro with /gopath/pkg/mod: directory not empty #54241

Closed
findleyr opened this issue Aug 3, 2022 · 2 comments
Closed

x/tools/gopls: TestSimultaneousEdits flaking on Kokoro with /gopath/pkg/mod: directory not empty #54241

findleyr opened this issue Aug 3, 2022 · 2 comments
Assignees
@findleyr
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.9.2

Comments

@findleyr
Copy link
Contributor

findleyr commented Aug 3, 2022

Just observed the following flake:
https://source.cloud.google.com/results/invocations/747b77b4-86df-4738-8ebf-9c38009a1fc0/targets/golang%2Ftools%2Fgopls-legacy%2Fpresubmit-114/log

It looks like we may have a race during cleanup of the shared directory.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Aug 3, 2022
@gopherbot gopherbot added this to the Unreleased milestone Aug 3, 2022
@dle8 dle8 modified the milestones: Unreleased, gopls/later Aug 4, 2022
@findleyr findleyr modified the milestones: gopls/later, gopls/v0.9.2 Aug 4, 2022
@gopherbot
Copy link

Change https://go.dev/cl/421258 mentions this issue: gopls/internal/regtest/misc: simplify shared edit tests

gopherbot pushed a commit to golang/tools that referenced this issue Aug 4, 2022
@findleyr
gopls/internal/regtest/misc: simplify shared edit tests
763f65c 
In order to avoid shutdown races we must always close the second editor
created for simultaneous edit tests.

Rather than introduce additional indirection, just merge the two tests
into one.

For golang/go#54241

Change-Id: I6604141baa77d07f6281d3a90efa13c02b94079a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/421258
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
@findleyr
Copy link
Contributor Author

findleyr commented Aug 4, 2022

I believe this should be resolved now. Tentatively closing.

@findleyr findleyr closed this as completed Aug 4, 2022
@findleyr findleyr mentioned this issue Aug 5, 2022
Closed
@findleyr findleyr self-assigned this Aug 8, 2022
@golang golang locked and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@findleyr findleyr

Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.9.2
Development

No branches or pull requests
3 participants
@gopherbot @dle8 @findleyr