Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/relui: workflow parameters of slice types aren't visibly shown #54240

Closed
dmitshur opened this issue Aug 3, 2022 · 7 comments
Closed

x/build/cmd/relui: workflow parameters of slice types aren't visibly shown #54240

dmitshur opened this issue Aug 3, 2022 · 7 comments
Assignees
@toothrot @dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Aug 3, 2022 •
edited

relui currently renders a recent "announce-and-tweet-minor" workflow from the Go 1.18.5 and 1.17.13 minor release:

image

The values for the string parameters "Version", "Security Summary", etc., are displayed, but not for the "Release Coordinator Names" and "Security Fixes" parameters, likely because their type is []string.

(The parameter values are there in the database and were correctly used by the tasks; this is only a presentation issue.)

CC @golang/release, @cherrymui.
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 3, 2022
@dmitshur dmitshur added this to the Unreleased milestone Aug 3, 2022
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 3, 2022
@dmitshur dmitshur mentioned this issue Aug 3, 2022
Closed
@dmitshur dmitshur added this to In Progress in Go Release Team Aug 9, 2022
@dmitshur
Copy link
Contributor Author

Looked at this briefly. As expected, it was only a problem for non-string parameters, and it's because the current parameter display code assumes all parameters are strings, which isn't always the case as of #51191.

Long term, we could extend the nice type-specific presentation that @toothrot did for results and outputs in #53382 to parameters too, but for now I'll mail a small CL that shows their JSON encoding, which is much better than invisible.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 10, 2022
@gopherbot
Copy link

Change https://go.dev/cl/422554 mentions this issue: internal/relui: display parameters, even if their type isn't string

@dmitshur dmitshur self-assigned this Aug 10, 2022
Go Release Team automation moved this from In Progress to Done Aug 10, 2022
@toothrot
Copy link
Contributor

This change breaks the layout a bit for some workflows. I am happy to fix it, though, and give it a little nicer visual treatment.

https://build.golang.org/releases/workflows/14dad363-ab84-41b7-af65-1928299f3390

9tAbAsV6PWWGQdD

@toothrot toothrot reopened this Aug 10, 2022
@dmitshur
Copy link
Contributor Author

Sure, thanks for helping!

@dmitshur dmitshur moved this from Done to In Progress in Go Release Team Aug 10, 2022
@toothrot
Copy link
Contributor

image

I'll send a CL that implements this screenshot. It's not perfect, but it's closer to something nice.

@gopherbot
Copy link

Change https://go.dev/cl/422599 mentions this issue: internal/relui: fix layout for large parameters

Go Release Team automation moved this from In Progress to Done Aug 11, 2022
@gopherbot
Copy link

Change https://go.dev/cl/443059 mentions this issue: internal/relui: remove workflowParams

gopherbot pushed a commit to golang/build that referenced this issue Oct 18, 2022
@dmitshur @gopherbot
internal/relui: remove workflowParams
2ca6ef6 
It's unused as of CL 422599.

For golang/go#54240.

Change-Id: I53628d167f0da8ae0bd255be230def3e8905aab4
Reviewed-on: https://go-review.googlesource.com/c/build/+/443059
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
@golang golang locked and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@toothrot toothrot

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@toothrot @dmitshur @gopherbot