Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/asm: document -p option in help text #54215

Closed
tdyas opened this issue Aug 3, 2022 · 3 comments
Closed

cmd/asm: document -p option in help text #54215

tdyas opened this issue Aug 3, 2022 · 3 comments
Assignees
@thanm
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.20

Comments

@tdyas
Copy link

tdyas commented Aug 3, 2022

What version of Go are you using (go version)?

Go v1.19

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

Not relevant since issue is with help text.

What did you do?

go doc cmd/asm

What did you expect to see?

I expected to see help text for the new -p option.

What did you see instead?

The help text does not include the new -p option.
@gopherbot gopherbot added compiler/runtime Issues related to the Go compiler and/or runtime. Documentation labels Aug 3, 2022
@thanm thanm self-assigned this Aug 3, 2022
@thanm thanm added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 3, 2022
@gopherbot
Copy link

Change https://go.dev/cl/420900 mentions this issue: cmd/asm: update package doc to describe "-p" option

@thanm
Copy link
Contributor

thanm commented Aug 3, 2022

Hopefully not too many folks are manually invoking "go tool asm" (as opposed to running "go build").

@tdyas
Copy link
Author

tdyas commented Aug 3, 2022

Hopefully not too many folks are manually invoking "go tool asm" (as opposed to running "go build").

Hopefully not, but I am because I maintain the Go backend for the Pants build tool.

@dmitshur dmitshur added this to the Go1.20 milestone Aug 3, 2022
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 3, 2022
jproberts pushed a commit to jproberts/go that referenced this issue Aug 10, 2022
@thanm @jproberts
cmd/asm: update package doc to describe "-p" option
e84a253 
Include a description of the assembler's "-p" command line option
in the package doc.

Fixes golang#54215.

Change-Id: I641abad573c37aa9447af6e8b84716093c2a2b70
Reviewed-on: https://go-review.googlesource.com/c/go/+/420900
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Than McIntosh <thanm@google.com>
@golang golang locked and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thanm thanm

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.20
Development

No branches or pull requests
4 participants
@tdyas @dmitshur @gopherbot @thanm