Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: opening an empty file crashes when gc_details is enabled #54199

Closed
findleyr opened this issue Aug 2, 2022 · 1 comment
Closed

x/tools/gopls: opening an empty file crashes when gc_details is enabled #54199

findleyr opened this issue Aug 2, 2022 · 1 comment
Assignees
@findleyr
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.9.2

Comments

@findleyr
Copy link
Contributor

findleyr commented Aug 2, 2022

When the gc_details codelens is enabled, asking for codelenses on an empty buffer crashes gopls due to a position error. This is a regression since v0.9.0, bisected to https://go.dev/cl/409935 (before that CL it was a bug report, so the root cause is likely to predate v0.9.0, but the crash is a regression).

Have a repro'ing regtest. Will send a fix.
@findleyr findleyr added this to the gopls/v0.9.2 milestone Aug 2, 2022
@findleyr findleyr self-assigned this Aug 2, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Aug 2, 2022
@gopherbot
Copy link

Change https://go.dev/cl/420715 mentions this issue: internal/lsp/source: don't crash requesting gc_details for an empty file

@golang golang locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@findleyr findleyr

Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.9.2
Development

No branches or pull requests
2 participants
@gopherbot @findleyr